You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ode.apache.org by "Veresh Jain (JIRA)" <ji...@apache.org> on 2010/07/07 23:38:53 UTC
[jira] Created: (ODE-868) PartnerLink Database operation failure
gives little information
PartnerLink Database operation failure gives little information
----------------------------------------------------------------
Key: ODE-868
URL: https://issues.apache.org/jira/browse/ODE-868
Project: ODE
Issue Type: Improvement
Components: BPEL Runtime
Affects Versions: 1.3.4
Reporter: Veresh Jain
When partnerlink name is long we get exception while inserting w/o knowing the column which caused the exception. For example a user might provide a very long partner role (> 100 characters) and that may cause the failure without giving more information.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ODE-868) PartnerLink Database operation failure
gives little information
Posted by "Veresh Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886122#action_12886122 ]
Veresh Jain commented on ODE-868:
---------------------------------
@Tammo I didn't wanted to change the method signature by throwing exception, throwing exception and catching would have been ideal but that would have required some more changes , I took a conservative approach to code change.
> PartnerLink Database operation failure gives little information
> ----------------------------------------------------------------
>
> Key: ODE-868
> URL: https://issues.apache.org/jira/browse/ODE-868
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 1.3.4
> Reporter: Veresh Jain
> Fix For: 1.3.5
>
> Attachments: verbose-error.patch
>
>
> When partnerlink name is long we get exception while inserting w/o knowing the column which caused the exception. For example a user might provide a very long partner role (> 100 characters) and that may cause the failure without giving more information.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ODE-868) PartnerLink Database operation failure
gives little information
Posted by "Tammo van Lessen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886117#action_12886117 ]
Tammo van Lessen commented on ODE-868:
--------------------------------------
Cool, thanks for the patch, Veresh!
Is there any reason for wrapping the exception into a RuntimeException?
I think
try {
getSession().save(epr);
} catch (HibernateException e) {
logDao.error("Error while saving Partner Link : " + epr.toString());
throw e;
}
would be a little bit nicer, just in case something is catching HibernateExceptions later.
WDYT?
> PartnerLink Database operation failure gives little information
> ----------------------------------------------------------------
>
> Key: ODE-868
> URL: https://issues.apache.org/jira/browse/ODE-868
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 1.3.4
> Reporter: Veresh Jain
> Fix For: 1.3.5
>
> Attachments: verbose-error.patch
>
>
> When partnerlink name is long we get exception while inserting w/o knowing the column which caused the exception. For example a user might provide a very long partner role (> 100 characters) and that may cause the failure without giving more information.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ODE-868) PartnerLink Database operation failure
gives little information
Posted by "Veresh Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Veresh Jain updated ODE-868:
----------------------------
Attachment: hib-runtime.patch
Changed runtime exception to Hibernate exception
> PartnerLink Database operation failure gives little information
> ----------------------------------------------------------------
>
> Key: ODE-868
> URL: https://issues.apache.org/jira/browse/ODE-868
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 1.3.4
> Reporter: Veresh Jain
> Fix For: 1.3.5
>
> Attachments: hib-runtime.patch, verbose-error.patch
>
>
> When partnerlink name is long we get exception while inserting w/o knowing the column which caused the exception. For example a user might provide a very long partner role (> 100 characters) and that may cause the failure without giving more information.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ODE-868) PartnerLink Database operation failure
gives little information
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888609#action_12888609 ]
Hudson commented on ODE-868:
----------------------------
Integrated in ODE-trunk #337 (See [http://hudson.zones.apache.org/hudson/job/ODE-trunk/337/])
> PartnerLink Database operation failure gives little information
> ----------------------------------------------------------------
>
> Key: ODE-868
> URL: https://issues.apache.org/jira/browse/ODE-868
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 1.3.4
> Reporter: Veresh Jain
> Fix For: 1.3.5
>
> Attachments: hib-runtime.patch, verbose-error.patch
>
>
> When partnerlink name is long we get exception while inserting w/o knowing the column which caused the exception. For example a user might provide a very long partner role (> 100 characters) and that may cause the failure without giving more information.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ODE-868) PartnerLink Database operation failure
gives little information
Posted by "Rafal Rusin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rafal Rusin resolved ODE-868.
-----------------------------
Fix Version/s: 1.3.5
Resolution: Fixed
Patch looks good. Thanks!
> PartnerLink Database operation failure gives little information
> ----------------------------------------------------------------
>
> Key: ODE-868
> URL: https://issues.apache.org/jira/browse/ODE-868
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 1.3.4
> Reporter: Veresh Jain
> Fix For: 1.3.5
>
> Attachments: verbose-error.patch
>
>
> When partnerlink name is long we get exception while inserting w/o knowing the column which caused the exception. For example a user might provide a very long partner role (> 100 characters) and that may cause the failure without giving more information.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ODE-868) PartnerLink Database operation failure
gives little information
Posted by "Veresh Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886138#action_12886138 ]
Veresh Jain commented on ODE-868:
---------------------------------
@Tammo on second thought I realized what you are saying so updating the patch.
> PartnerLink Database operation failure gives little information
> ----------------------------------------------------------------
>
> Key: ODE-868
> URL: https://issues.apache.org/jira/browse/ODE-868
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 1.3.4
> Reporter: Veresh Jain
> Fix For: 1.3.5
>
> Attachments: verbose-error.patch
>
>
> When partnerlink name is long we get exception while inserting w/o knowing the column which caused the exception. For example a user might provide a very long partner role (> 100 characters) and that may cause the failure without giving more information.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ODE-868) PartnerLink Database operation failure
gives little information
Posted by "Veresh Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Veresh Jain updated ODE-868:
----------------------------
Attachment: verbose-error.patch
This patch takes care of the issue which comes while inseting large column values into partner link. Verbose error will be thrown when error comes for users to take corrective actions.
Ideally we should do for all insert update operation but for now partner link is taken care via this.
> PartnerLink Database operation failure gives little information
> ----------------------------------------------------------------
>
> Key: ODE-868
> URL: https://issues.apache.org/jira/browse/ODE-868
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 1.3.4
> Reporter: Veresh Jain
> Attachments: verbose-error.patch
>
>
> When partnerlink name is long we get exception while inserting w/o knowing the column which caused the exception. For example a user might provide a very long partner role (> 100 characters) and that may cause the failure without giving more information.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.