You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Julian Hyde <ju...@gmail.com> on 2014/12/12 18:56:28 UTC

Build failure

Vladimir,

Your recent change caused errors in ‘mvn site’ under JDK 1.8. Can you fix please?

The Travis job also failed under JDK 1.7 with “no space left on device” errors but let’s assume that was a transient glitch.

Julian

https://travis-ci.org/julianhyde/incubator-calcite/builds/43853673

https://s3.amazonaws.com/archive.travis-ci.org/jobs/43853674/log.txt



Re: Build failure

Posted by Julian Hyde <ju...@gmail.com>.
I made one comment on the pull request, but otherwise, looks good.

I didn’t intend you to fix the errors, but thanks for fixing all of the warnings (e.g. missing @return) too.

Julian

PS Your English is just fine.

On Dec 12, 2014, at 1:05 PM, Vladimir Sitnikov <si...@gmail.com> wrote:

> Please review https://github.com/apache/incubator-calcite/pull/30
> 
> I struggle when I write in English. Feel free to update wording, so I
> can learn something from that.
> Vladimir


Re: Build failure

Posted by Vladimir Sitnikov <si...@gmail.com>.
Please review https://github.com/apache/incubator-calcite/pull/30

I struggle when I write in English. Feel free to update wording, so I
can learn something from that.
Vladimir

Re: Build failure

Posted by Vladimir Sitnikov <si...@gmail.com>.
No problem, will fix.

Thanks for the reminder.

Regards,
Vladimir Sitnikov