[GitHub] [kvrocks] Yangsx-1 commented on a diff in pull request #1601: Add an archlinux environment for building and testing in CI

["Yangsx-1 (via GitHub)" <gi...@apache.org>]

Yangsx-1 commented on code in PR #1601:
URL: https://github.com/apache/kvrocks/pull/1601#discussion_r1270943822


##########
.github/workflows/kvrocks.yaml:
##########
@@ -338,11 +346,15 @@ jobs:
         with:
           go-version-file: 'tests/gocase/go.mod'
 
-      - name: Build Kvrocks
+      - name: Build Kvrocks for CentOS
         if: ${{ startsWith(matrix.image, 'centos') }}
         run: |
           source /opt/rh/devtoolset-11/enable

Review Comment:
   > @PragmaTwice is it possible we move this line to the setup stage so that all "Build Kvrocks" share the same script?
   
   I found a way to do this, maybe not elegant.  :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org