You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/12/24 23:14:24 UTC

[GitHub] [storm] zeahoo commented on a change in pull request #3368: [STORM-3729] fix assgin memory error over 2g

zeahoo commented on a change in pull request #3368:
URL: https://github.com/apache/storm/pull/3368#discussion_r548761367



##########
File path: storm-client/test/jvm/org/apache/storm/utils/UtilsTest.java
##########
@@ -89,7 +89,9 @@ private void doParseJvmHeapMemByChildOptsTest(String message, String opt, double
     }
 
     private void doParseJvmHeapMemByChildOptsTest(String message, List<String> opts, double expected) {
-        Assert.assertEquals(message, Utils.parseJvmHeapMemByChildOpts(opts, 123.0), expected, 0);
+        Assert.assertEquals(
+            message,
+            expected, Utils.parseJvmHeapMemByChildOpts(opts, 123.0).doubleValue(), 0);

Review comment:
       remove it :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org