[jira] [Created] (GUACAMOLE-2074) Disagreement in signedness causes assertion failures with FreeRDP 3.x

["Mike Jumper (Jira)" <ji...@apache.org>]

Mike Jumper created GUACAMOLE-2074:
--------------------------------------

             Summary: Disagreement in signedness causes assertion failures with FreeRDP 3.x
                 Key: GUACAMOLE-2074
                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-2074
             Project: Guacamole
          Issue Type: Bug
          Components: RDP
            Reporter: Mike Jumper


In some parts of Guacamole's RDPDR support, signed integers are used to store values that actually should be unsigned. In the case of RDPDR status codes, those values are large enough that they become negative and fail sanity checks when written to the RDP PDU with FreeRDP 3.x:

{code:none}
Assertion failed: (((status) >= 0)) (channels/rdpdr/rdpdr.c: guac_rdpdr_new_io_completion: 137)
{code}

This did not fail previously as FreeRDP 2.x simply wrote the values in binary form, effectively ignoring signedness.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)