[GitHub] [beam] robinyqiu commented on a change in pull request #12163: [BEAM-9712] Refactor ZetaSQL planner code and support setting default timezone

[GitBox <gi...@apache.org>]

robinyqiu commented on a change in pull request #12163:
URL: https://github.com/apache/beam/pull/12163#discussion_r450446417



##########
File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java
##########
@@ -65,9 +65,12 @@ public ZetaSQLQueryPlanner(FrameworkConfig config) {
     plannerImpl = new ZetaSQLPlannerImpl(config);
   }
 
-  public ZetaSQLQueryPlanner(JdbcConnection jdbcConnection, RuleSet[] ruleSets) {
+  // Called by BeamSqlEnv.instantiatePlanner() reflectively

Review comment:
       Done.

##########
File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java
##########
@@ -187,8 +167,10 @@ static AnalyzerOptions initAnalyzerOptions() {
     return options;
   }
 
-  static AnalyzerOptions initAnalyzerOptions(QueryParameters queryParams) {
-    AnalyzerOptions options = initAnalyzerOptions();
+  static AnalyzerOptions initAnalyzerOptions(QueryParameters queryParams, String defaultTimezone) {

Review comment:
       Done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org