You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by Patrick Davids <pa...@nubologic.com> on 2016/03/07 15:10:41 UTC
clearInput() if FormComponentPanel does not delegate to its inner
FormComponents
Hi Wicket Pros,
is it bug or an feature, that FormComponentPanel is not overriding
clearInput() to delegate the clearing to its inner FormComponents?
For me, it should behave the same way, when extending FormComponent.
But I'm not sure here about consequences...
(As I can see... Form.clearInput() features this by visiting its inner
FormComponents.)
kind regards
Patrick
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: clearInput() if FormComponentPanel does not delegate to its inner FormComponents
Posted by Martin Grigorov <mg...@apache.org>.
Done with https://issues.apache.org/jira/browse/WICKET-6114
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Mon, Mar 7, 2016 at 5:28 PM, Sven Meier <sv...@meiers.net> wrote:
> Sure, changes in 8.x won't break anything :P
>
> Sven
>
>
> On 07.03.2016 15:49, Martin Grigorov wrote:
>
>> Hi,
>>
>> I think consistency is very important.
>> I'm +1 to make the change. At least in Wicket 8.x
>>
>> Martin Grigorov
>> Wicket Training and Consulting
>> https://twitter.com/mtgrigorov
>>
>> On Mon, Mar 7, 2016 at 3:24 PM, Sven Meier <sv...@meiers.net> wrote:
>>
>> Hi,
>>>
>>> it always has been that way.
>>> I'm not aware of any benefit which would justify a change - besides
>>> consistency.
>>>
>>> Have fun
>>> Sven
>>>
>>>
>>>
>>> On 07.03.2016 15:10, Patrick Davids wrote:
>>>
>>> Hi Wicket Pros,
>>>>
>>>> is it bug or an feature, that FormComponentPanel is not overriding
>>>> clearInput() to delegate the clearing to its inner FormComponents?
>>>>
>>>> For me, it should behave the same way, when extending FormComponent.
>>>> But I'm not sure here about consequences...
>>>>
>>>> (As I can see... Form.clearInput() features this by visiting its inner
>>>> FormComponents.)
>>>>
>>>> kind regards
>>>> Patrick
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>>>> For additional commands, e-mail: users-help@wicket.apache.org
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>>> For additional commands, e-mail: users-help@wicket.apache.org
>>>
>>>
>>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
Re: clearInput() if FormComponentPanel does not delegate to its inner
FormComponents
Posted by Sven Meier <sv...@meiers.net>.
Sure, changes in 8.x won't break anything :P
Sven
On 07.03.2016 15:49, Martin Grigorov wrote:
> Hi,
>
> I think consistency is very important.
> I'm +1 to make the change. At least in Wicket 8.x
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Mon, Mar 7, 2016 at 3:24 PM, Sven Meier <sv...@meiers.net> wrote:
>
>> Hi,
>>
>> it always has been that way.
>> I'm not aware of any benefit which would justify a change - besides
>> consistency.
>>
>> Have fun
>> Sven
>>
>>
>>
>> On 07.03.2016 15:10, Patrick Davids wrote:
>>
>>> Hi Wicket Pros,
>>>
>>> is it bug or an feature, that FormComponentPanel is not overriding
>>> clearInput() to delegate the clearing to its inner FormComponents?
>>>
>>> For me, it should behave the same way, when extending FormComponent.
>>> But I'm not sure here about consequences...
>>>
>>> (As I can see... Form.clearInput() features this by visiting its inner
>>> FormComponents.)
>>>
>>> kind regards
>>> Patrick
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>>> For additional commands, e-mail: users-help@wicket.apache.org
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: clearInput() if FormComponentPanel does not delegate to its inner FormComponents
Posted by Martin Grigorov <mg...@apache.org>.
Hi,
I think consistency is very important.
I'm +1 to make the change. At least in Wicket 8.x
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Mon, Mar 7, 2016 at 3:24 PM, Sven Meier <sv...@meiers.net> wrote:
> Hi,
>
> it always has been that way.
> I'm not aware of any benefit which would justify a change - besides
> consistency.
>
> Have fun
> Sven
>
>
>
> On 07.03.2016 15:10, Patrick Davids wrote:
>
>> Hi Wicket Pros,
>>
>> is it bug or an feature, that FormComponentPanel is not overriding
>> clearInput() to delegate the clearing to its inner FormComponents?
>>
>> For me, it should behave the same way, when extending FormComponent.
>> But I'm not sure here about consequences...
>>
>> (As I can see... Form.clearInput() features this by visiting its inner
>> FormComponents.)
>>
>> kind regards
>> Patrick
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
Re: clearInput() if FormComponentPanel does not delegate to its inner
FormComponents
Posted by Sven Meier <sv...@meiers.net>.
Hi,
it always has been that way.
I'm not aware of any benefit which would justify a change - besides
consistency.
Have fun
Sven
On 07.03.2016 15:10, Patrick Davids wrote:
> Hi Wicket Pros,
>
> is it bug or an feature, that FormComponentPanel is not overriding
> clearInput() to delegate the clearing to its inner FormComponents?
>
> For me, it should behave the same way, when extending FormComponent.
> But I'm not sure here about consequences...
>
> (As I can see... Form.clearInput() features this by visiting its inner
> FormComponents.)
>
> kind regards
> Patrick
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org