You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/06/21 02:31:47 UTC

Review Request 70918: Removed `setQuota` and `removeQuota` methods in the allocator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70918/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-9820
    https://issues.apache.org/jira/browse/MESOS-9820


Repository: mesos


Description
-------

These are replaced by the `updateQuota` method.


Diffs
-----

  include/mesos/allocator/allocator.hpp 0aef0030e78514bef731b80de5b4bb3a567811e4 
  src/master/allocator/mesos/allocator.hpp 0ae7e3697327832a0f95e2cd7339d8876e815be8 
  src/master/allocator/mesos/hierarchical.hpp 25472eb7f5cb8342d2c88449c9c4145d816fb718 
  src/master/allocator/mesos/hierarchical.cpp c9ed094fcd67c1d8896fe380274ef8e08d5af892 
  src/master/allocator/mesos/metrics.hpp a0953b0cf716489ab94ae54026e8328830ea719e 
  src/master/allocator/mesos/metrics.cpp b61a39b1cd8e15043a68337b20b057c70903115f 
  src/master/quota_handler.cpp 854189cd052cc88b4dc0ade72c63ac9a1b0bcbb5 
  src/tests/allocator.hpp 765968d5bf9846324d8d7f1d3f6687155c9ea2b5 


Diff: https://reviews.apache.org/r/70918/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu

Re: Review Request 70918: Removed `setQuota` and `removeQuota` methods in the allocator.

Posted by Benjamin Mahler <bm...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70918/#review216111
-----------------------------------------------------------


Fix it, then Ship it!





src/master/allocator/mesos/metrics.cpp
Lines 199-201 (original), 138-140 (patched)
<https://reviews.apache.org/r/70918/#comment303105>

    Seems like this is not the behavior we want, I thought we added a TODO here to always expose the allocated gauge?


- Benjamin Mahler


On June 21, 2019, 2:31 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70918/
> -----------------------------------------------------------
> 
> (Updated June 21, 2019, 2:31 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9820
>     https://issues.apache.org/jira/browse/MESOS-9820
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These are replaced by the `updateQuota` method.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp 0aef0030e78514bef731b80de5b4bb3a567811e4 
>   src/master/allocator/mesos/allocator.hpp 0ae7e3697327832a0f95e2cd7339d8876e815be8 
>   src/master/allocator/mesos/hierarchical.hpp 25472eb7f5cb8342d2c88449c9c4145d816fb718 
>   src/master/allocator/mesos/hierarchical.cpp c9ed094fcd67c1d8896fe380274ef8e08d5af892 
>   src/master/allocator/mesos/metrics.hpp a0953b0cf716489ab94ae54026e8328830ea719e 
>   src/master/allocator/mesos/metrics.cpp b61a39b1cd8e15043a68337b20b057c70903115f 
>   src/master/quota_handler.cpp 854189cd052cc88b4dc0ade72c63ac9a1b0bcbb5 
>   src/tests/allocator.hpp 765968d5bf9846324d8d7f1d3f6687155c9ea2b5 
> 
> 
> Diff: https://reviews.apache.org/r/70918/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>