You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/06 12:40:08 UTC

[GitHub] [rocketmq] areyouok opened a new pull request #3588: [ISSUE 3585] [Part B] Improve encode/decode performance

areyouok opened a new pull request #3588:
URL: https://github.com/apache/rocketmq/pull/3588


   1. [Part B] Improve header encode/decode performance
   2. [Part B] Improve RocketMQSerializable performance with zero-copy


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #3588: [ISSUE 3585] [Part B] Improve encode/decode performance

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3588:
URL: https://github.com/apache/rocketmq/pull/3588#issuecomment-987859133


   
   [![Coverage Status](https://coveralls.io/builds/45038362/badge)](https://coveralls.io/builds/45038362)
   
   Coverage increased (+0.1%) to 56.254% when pulling **1502b35f22b6560b682b2c618612fdb63667bd5e on areyouok:492_PartB** into **ecb061ae425f76ad28a597293b98f374ceba14ec on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] yuz10 commented on a change in pull request #3588: [ISSUE 3585] [Part B] Improve encode/decode performance

Posted by GitBox <gi...@apache.org>.
yuz10 commented on a change in pull request #3588:
URL: https://github.com/apache/rocketmq/pull/3588#discussion_r776601466



##########
File path: common/src/test/java/org/apache/rocketmq/common/protocol/header/FastCodesHeaderTest.java
##########
@@ -65,9 +75,11 @@ public void testDecodeSendMessageHeaderV2() throws Exception {
         return extFields;
     }
 
-    private void check(RemotingCommand command, List<Field> fields) throws Exception {
-        SendMessageRequestHeaderV2 o1 = (SendMessageRequestHeaderV2) command.decodeCommandCustomHeader(SendMessageRequestHeaderV2.class);
-        SendMessageRequestHeaderV2 o2 = AbstractSendMessageProcessor.decodeSendMessageHeaderV2(command);
+    private void check(RemotingCommand command, List<Field> fields,
+            Class<? extends CommandCustomHeader> classHeader) throws Exception {
+        CommandCustomHeader o1 = command.decodeCommandCustomHeader(classHeader);

Review comment:
       If the classHeader is instance of FastCodesHeader, command.decodeCommandCustomHeader(classHeader) also calls fast decode, the result will always be the same




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #3588: [ISSUE 3585] [Part B] Improve encode/decode performance

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3588:
URL: https://github.com/apache/rocketmq/pull/3588#issuecomment-987859133


   
   [![Coverage Status](https://coveralls.io/builds/44817135/badge)](https://coveralls.io/builds/44817135)
   
   Coverage increased (+0.06%) to 55.192% when pulling **faba1e73b45a2b28891ec17bacc572bc70984685 on areyouok:492_PartB** into **a779d69862c69db0d84fc27b35cfe5d08dc96377 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #3588: [ISSUE 3585] [Part B] Improve encode/decode performance

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3588:
URL: https://github.com/apache/rocketmq/pull/3588#issuecomment-987859133


   
   [![Coverage Status](https://coveralls.io/builds/45047836/badge)](https://coveralls.io/builds/45047836)
   
   Coverage increased (+0.06%) to 56.206% when pulling **bcfb96a4ed100ccbd423dd7ceb48c5ca42a3b80a on areyouok:492_PartB** into **ecb061ae425f76ad28a597293b98f374ceba14ec on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #3588: [ISSUE 3585] [Part B] Improve encode/decode performance

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3588:
URL: https://github.com/apache/rocketmq/pull/3588#issuecomment-987859133


   
   [![Coverage Status](https://coveralls.io/builds/45293747/badge)](https://coveralls.io/builds/45293747)
   
   Coverage decreased (-2.8%) to 53.331% when pulling **4f47ef23088259debb6ee9f2c468eae13192f7ae on areyouok:492_PartB** into **ecb061ae425f76ad28a597293b98f374ceba14ec on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] vongosling commented on pull request #3588: [ISSUE 3585] [Part B] Improve encode/decode performance

Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #3588:
URL: https://github.com/apache/rocketmq/pull/3588#issuecomment-1085329392


   Support go ahead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] yuz10 commented on a change in pull request #3588: [ISSUE 3585] [Part B] Improve encode/decode performance

Posted by GitBox <gi...@apache.org>.
yuz10 commented on a change in pull request #3588:
URL: https://github.com/apache/rocketmq/pull/3588#discussion_r776595912



##########
File path: common/src/main/java/org/apache/rocketmq/common/protocol/header/SendMessageResponseHeader.java
##########
@@ -37,6 +42,37 @@
     public void checkFields() throws RemotingCommandException {
     }
 
+    @Override
+    public void encode(ByteBuf out) {
+        writeIfNotNull(out, "msgId", msgId);
+        writeIfNotNull(out, "queueId", queueId);
+        writeIfNotNull(out, "queueOffset", queueOffset);
+        writeIfNotNull(out, "transactionId", transactionId);
+    }
+
+    @Override
+    public void decode(HashMap<String, String> fields) throws RemotingCommandException {
+        String str = getAndCheckNotNull(fields, "msgId");

Review comment:
       It would be better to add a test to compare the old decode result and fast decode result in case we add a new field later.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls edited a comment on pull request #3588: [ISSUE 3585] [Part B] Improve encode/decode performance

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3588:
URL: https://github.com/apache/rocketmq/pull/3588#issuecomment-987859133


   
   [![Coverage Status](https://coveralls.io/builds/44820602/badge)](https://coveralls.io/builds/44820602)
   
   Coverage increased (+0.03%) to 55.163% when pulling **196c1e22887c342944ef375d0fd12983ef98e828 on areyouok:492_PartB** into **a779d69862c69db0d84fc27b35cfe5d08dc96377 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] xujianhai666 commented on a change in pull request #3588: [ISSUE 3585] [Part B] Improve encode/decode performance

Posted by GitBox <gi...@apache.org>.
xujianhai666 commented on a change in pull request #3588:
URL: https://github.com/apache/rocketmq/pull/3588#discussion_r764501164



##########
File path: remoting/src/main/java/org/apache/rocketmq/remoting/protocol/FastCodesHeader.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.remoting.protocol;
+
+import java.util.HashMap;
+
+import org.apache.rocketmq.remoting.exception.RemotingCommandException;
+
+import io.netty.buffer.ByteBuf;
+
+public interface FastCodesHeader {
+
+    default String getAndCheckNotNull(HashMap<String, String> fields, String field) {
+        String value = fields.get(field);
+        if (value == null) {
+            String headerClass = this.getClass().getSimpleName();

Review comment:
       maybe cached headerClasss is beffer




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] yuz10 commented on a change in pull request #3588: [ISSUE 3585] [Part B] Improve encode/decode performance

Posted by GitBox <gi...@apache.org>.
yuz10 commented on a change in pull request #3588:
URL: https://github.com/apache/rocketmq/pull/3588#discussion_r776601844



##########
File path: common/src/main/java/org/apache/rocketmq/common/protocol/header/SendMessageResponseHeader.java
##########
@@ -37,6 +42,37 @@
     public void checkFields() throws RemotingCommandException {
     }
 
+    @Override
+    public void encode(ByteBuf out) {
+        writeIfNotNull(out, "msgId", msgId);
+        writeIfNotNull(out, "queueId", queueId);
+        writeIfNotNull(out, "queueOffset", queueOffset);
+        writeIfNotNull(out, "transactionId", transactionId);
+    }
+
+    @Override
+    public void decode(HashMap<String, String> fields) throws RemotingCommandException {
+        String str = getAndCheckNotNull(fields, "msgId");

Review comment:
       I found the tests, please ignore it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] areyouok commented on a change in pull request #3588: [ISSUE 3585] [Part B] Improve encode/decode performance

Posted by GitBox <gi...@apache.org>.
areyouok commented on a change in pull request #3588:
URL: https://github.com/apache/rocketmq/pull/3588#discussion_r764574497



##########
File path: remoting/src/main/java/org/apache/rocketmq/remoting/protocol/FastCodesHeader.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.remoting.protocol;
+
+import java.util.HashMap;
+
+import org.apache.rocketmq.remoting.exception.RemotingCommandException;
+
+import io.netty.buffer.ByteBuf;
+
+public interface FastCodesHeader {
+
+    default String getAndCheckNotNull(HashMap<String, String> fields, String field) {
+        String value = fields.get(field);
+        if (value == null) {
+            String headerClass = this.getClass().getSimpleName();

Review comment:
       Here is an exception branch, there is no need to cache the headerCalss string.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] areyouok commented on pull request #3588: [ISSUE 3585] [Part B] Improve encode/decode performance

Posted by GitBox <gi...@apache.org>.
areyouok commented on pull request #3588:
URL: https://github.com/apache/rocketmq/pull/3588#issuecomment-1010569771


   > In request or response header, some `Integer` fields(queueId, sysFlag, etc) are assigned by `java.lang.Integer#parseInt(java.lang.String)`. Is it more appropriate to use `java.lang.Integer#valueOf(java.lang.String)` to prevent auto-boxing? `valueOf()` will use `IntegerCache`, but the behavior of auto-boxing depends on the implementation of compiler.
   
   The java 8 compiler use Integer.valueOf(Integer) for auto-boxing, frequently requested values is caching.
   
   By the way, the rocketmq header objects should use primitive types, but I do not change this time.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #3588: [ISSUE 3585] [Part B] Improve encode/decode performance

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3588:
URL: https://github.com/apache/rocketmq/pull/3588#issuecomment-1002998634


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3588?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3588](https://codecov.io/gh/apache/rocketmq/pull/3588?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4f47ef2) into [develop](https://codecov.io/gh/apache/rocketmq/commit/ecb061ae425f76ad28a597293b98f374ceba14ec?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ecb061a) will **decrease** coverage by `2.40%`.
   > The diff coverage is `57.95%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/3588/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq/pull/3588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #3588      +/-   ##
   =============================================
   - Coverage      49.69%   47.29%   -2.41%     
   - Complexity      4725     5052     +327     
   =============================================
     Files            555      628      +73     
     Lines          36798    41479    +4681     
     Branches        4853     5409     +556     
   =============================================
   + Hits           18286    19616    +1330     
   - Misses         16214    19407    +3193     
   - Partials        2298     2456     +158     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...broker/processor/AbstractSendMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0Fic3RyYWN0U2VuZE1lc3NhZ2VQcm9jZXNzb3IuamF2YQ==) | `40.37% <0.00%> (-8.93%)` | :arrow_down: |
   | [...he/rocketmq/remoting/protocol/FastCodesHeader.java](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL0Zhc3RDb2Rlc0hlYWRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...on/protocol/header/SendMessageRequestHeaderV2.java](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvaGVhZGVyL1NlbmRNZXNzYWdlUmVxdWVzdEhlYWRlclYyLmphdmE=) | `23.20% <50.90%> (+23.19%)` | :arrow_up: |
   | [...mmon/protocol/header/PullMessageRequestHeader.java](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvaGVhZGVyL1B1bGxNZXNzYWdlUmVxdWVzdEhlYWRlci5qYXZh) | `30.86% <51.06%> (+30.86%)` | :arrow_up: |
   | [...mon/protocol/header/PullMessageResponseHeader.java](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvaGVhZGVyL1B1bGxNZXNzYWdlUmVzcG9uc2VIZWFkZXIuamF2YQ==) | `34.37% <52.63%> (+34.37%)` | :arrow_up: |
   | [...mon/protocol/header/SendMessageResponseHeader.java](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvaGVhZGVyL1NlbmRNZXNzYWdlUmVzcG9uc2VIZWFkZXIuamF2YQ==) | `34.37% <52.63%> (+34.37%)` | :arrow_up: |
   | [...he/rocketmq/remoting/protocol/RemotingCommand.java](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL1JlbW90aW5nQ29tbWFuZC5qYXZh) | `72.83% <61.76%> (-5.80%)` | :arrow_down: |
   | [...cketmq/remoting/protocol/RocketMQSerializable.java](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL1JvY2tldE1RU2VyaWFsaXphYmxlLmphdmE=) | `85.12% <80.35%> (-1.34%)` | :arrow_down: |
   | [...ocketmq/broker/processor/SendMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1NlbmRNZXNzYWdlUHJvY2Vzc29yLmphdmE=) | `39.74% <100.00%> (-0.16%)` | :arrow_down: |
   | [...g/apache/rocketmq/remoting/netty/NettyDecoder.java](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5RGVjb2Rlci5qYXZh) | `87.50% <100.00%> (-0.74%)` | :arrow_down: |
   | ... and [100 more](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/3588?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3588?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ecb061a...4f47ef2](https://codecov.io/gh/apache/rocketmq/pull/3588?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org