You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2016/02/06 17:24:04 UTC

[10/15] lucene-solr git commit: add nocommit; try to fix false test failure due to concurrent check index running while primary is still closing

add nocommit; try to fix false test failure due to concurrent check index running while primary is still closing


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/7af83c48
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/7af83c48
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/7af83c48

Branch: refs/heads/jira/lucene-5438-nrt-replication
Commit: 7af83c486b50ceb13d58e79dd65c158bc96130dc
Parents: 8889469
Author: Mike McCandless <mi...@apache.org>
Authored: Wed Feb 3 16:45:46 2016 -0500
Committer: Mike McCandless <mi...@apache.org>
Committed: Wed Feb 3 16:45:46 2016 -0500

----------------------------------------------------------------------
 .../src/test/org/apache/lucene/replicator/nrt/NodeProcess.java   | 4 +---
 .../org/apache/lucene/replicator/nrt/TestNRTReplication.java     | 2 ++
 2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/7af83c48/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/NodeProcess.java
----------------------------------------------------------------------
diff --git a/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/NodeProcess.java b/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/NodeProcess.java
index dcbef87..be0b3df3 100644
--- a/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/NodeProcess.java
+++ b/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/NodeProcess.java
@@ -157,9 +157,7 @@ class NodeProcess implements Closeable {
             throw new RuntimeException("shutdown failed");
           }
         } catch (Throwable t) {
-          System.out.println("top: shutdown failed; skipping");
-          t.printStackTrace(System.out);
-          return false;
+          System.out.println("top: shutdown failed; ignoring");
         }
         try {
           p.waitFor();

http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/7af83c48/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
----------------------------------------------------------------------
diff --git a/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java b/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
index b2240eb..510a075 100644
--- a/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
+++ b/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java
@@ -37,6 +37,8 @@ import org.apache.lucene.util.LuceneTestCase.SuppressSysoutChecks;
 
 import com.carrotsearch.randomizedtesting.SeedUtils;
 
+// nocommit make some explicit failure tests
+
 // MockRandom's .sd file has no index header/footer:
 @SuppressCodecs({"MockRandom", "Memory", "Direct", "SimpleText"})
 @SuppressSysoutChecks(bugUrl = "Stuff gets printed, important stuff for debugging a failure")