[GitHub] [pinot] walterddr commented on a change in pull request #7678: Fixing DISTINCT with AS function

[GitBox <gi...@apache.org>]

walterddr commented on a change in pull request #7678:
URL: https://github.com/apache/pinot/pull/7678#discussion_r741355485



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TransformFunctionFactory.java
##########
@@ -198,6 +199,9 @@ public static TransformFunction get(ExpressionContext expression, Map<String, Da
         FunctionContext function = expression.getFunction();
         String functionName = canonicalize(function.getFunctionName());
         List<ExpressionContext> arguments = function.getArguments();
+        if (functionName.equalsIgnoreCase("AS")) {
+          arguments = arguments.subList(0, 1);
+        }

Review comment:
       why not just pass both of them in? it shouldn't matter as long as `AsTransformFunction` handles it correctly yes?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org