You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/06 09:28:52 UTC

[GitHub] [flink] kl0u edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink

kl0u edited a comment on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink 
URL: https://github.com/apache/flink/pull/9581#issuecomment-528767272
 
 
   Hi @yxu-valleytider , I am reviewing the PR now.
   The tests should be also part of the PR as this PR adds a new feature (subclassing the `StreamingFileSink`).
   
   Also how could the subclasses that want this functionality subclass this method is they do not have access to the internal fields for the constructor? This means we should also add getters, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services