[jira] [Commented] (KAFKA-7489) ConnectDistributedTest is always running broker with dev version

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-7489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028674#comment-17028674 ] 

ASF GitHub Bot commented on KAFKA-7489:
---------------------------------------

gharris1727 commented on pull request #8035: KAFKA-7489: Remove 0.9 compatibility checks from ConnectDistributedTest
URL: https://github.com/apache/kafka/pull/8035
 
 
   (#7023) exposed an incompatibility between Kafka <=0.9 and Connect >0.9,
   in which the broker does not recognize a request for ApiVersions.
   For trunk and 2.4, this test case was removed rather than the issue addressed.
   This effectively backports the other half of (#7023) which was left out of (#7791).
   
   Signed-off-by: Greg Harris <gr...@confluent.io>
   
   It is necessary to backport this to all of the branches that #7791 was backported to, namely `2.2` and `2.1`.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> ConnectDistributedTest is always running broker with dev version
> ----------------------------------------------------------------
>
>                 Key: KAFKA-7489
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7489
>             Project: Kafka
>          Issue Type: Test
>          Components: KafkaConnect, system tests
>            Reporter: Andras Katona
>            Assignee: Randall Hauch
>            Priority: Major
>             Fix For: 2.1.2, 2.2.3, 2.3.2
>
>
> h2. Test class
> kafkatest.tests.connect.connect_distributed_test.ConnectDistributedTest
> h2. Details
> _test_broker_compatibility_ is +parametrized+ with different types of brokers, yet it is passed as string to _setup_services_ and this way KafkaService is initialised with DEV version in the end.
> This is easy to fix, just wrap the _broker_version_ with KafkaVersion
> {panel}
> self.setup_services(broker_version={color:#FF0000}KafkaVersion{color}(broker_version), auto_create_topics=auto_create_topics, security_protocol=security_protocol)
> {panel}
> But test is failing with the parameter LATEST_0_9 with the following error message
> {noformat}
> Kafka Connect failed to start on node: ducker@ducker02 in condition mode: LISTEN
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)