You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Mykhailo Tiutin (JIRA)" <ji...@apache.org> on 2009/07/29 14:04:14 UTC

[jira] Created: (DIRMINA-732) Session Idle events never comes in sessions managed by NioDatagramAcceptor

Session Idle events never comes in sessions managed by NioDatagramAcceptor
--------------------------------------------------------------------------

                 Key: DIRMINA-732
                 URL: https://issues.apache.org/jira/browse/DIRMINA-732
             Project: MINA
          Issue Type: Bug
          Components: Core
    Affects Versions: 2.0.0-M6
         Environment: Any
            Reporter: Mykhailo Tiutin
            Priority: Minor


Idle events never appears in sessions managed by NioDatagramAcceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-732) Session Idle events never comes in sessions managed by NioDatagramAcceptor

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736861#action_12736861 ] 

Emmanuel Lecharny commented on DIRMINA-732:
-------------------------------------------

Seems to be a reasonable patch, as far as I can tell.

Probably the same mechanism that we have in AbstractPollingIoConnector.

Will review the patch in detail.

Thanks !

> Session Idle events never comes in sessions managed by NioDatagramAcceptor
> --------------------------------------------------------------------------
>
>                 Key: DIRMINA-732
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-732
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M6
>         Environment: Any
>            Reporter: Mykhailo Tiutin
>            Priority: Minor
>         Attachments: DatagramSessionIdleTest.java, DatagramSessionIdleTimePatch
>
>
> Idle events never appears in sessions managed by NioDatagramAcceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DIRMINA-732) Session Idle events never comes in sessions managed by NioDatagramAcceptor

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny updated DIRMINA-732:
--------------------------------------

    Fix Version/s:     (was: 2.0.0-RC2)
                   2.0.0

> Session Idle events never comes in sessions managed by NioDatagramAcceptor
> --------------------------------------------------------------------------
>
>                 Key: DIRMINA-732
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-732
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M6
>         Environment: Any
>            Reporter: Mykhailo Tiutin
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: DatagramSessionIdleTest.java, DatagramSessionIdleTimePatch
>
>
> Idle events never appears in sessions managed by NioDatagramAcceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DIRMINA-732) Session Idle events never comes in sessions managed by NioDatagramAcceptor

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny resolved DIRMINA-732.
---------------------------------------

    Resolution: Fixed

Fixed in http://svn.apache.org/viewvc?rev=899366&view=rev

> Session Idle events never comes in sessions managed by NioDatagramAcceptor
> --------------------------------------------------------------------------
>
>                 Key: DIRMINA-732
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-732
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M6
>         Environment: Any
>            Reporter: Mykhailo Tiutin
>            Priority: Minor
>         Attachments: DatagramSessionIdleTest.java, DatagramSessionIdleTimePatch
>
>
> Idle events never appears in sessions managed by NioDatagramAcceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (DIRMINA-732) Session Idle events never comes in sessions managed by NioDatagramAcceptor

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny reopened DIRMINA-732:
---------------------------------------


It's totally fucked up. 

The fix is OK, but it's a hack.

The real issue is that when we create a socket using 

InetSocketAddress bindAddress = new InetSocketAddress(AvailablePortFinder.getNextAvailable()), 

it creates an IPV4 address (/0.0.0.0:XXXX). Then we create the acceptor, and bind this address on it.

The code for acceptor.bind(SocketAddress localAddress) is doing :
DatagramChannel c = DatagramChannel.open();
...
c.configureBlocking(false);
c.socket.bind(localAddress); // Here, localAddress value is /0.0.0.0:XXXX
// and here, c.localAddress value is an IPV6 address : /0:0:0:0:0:0:0:0:XXXX

Why not ...

*but*, when we do :
IoSession session = acceptor.newSession(new InetSocketAddress(
                "127.0.0.1", AvailablePortFinder.getNextAvailable()), bindAddress);

on the client, the bindAddress is an IPV4 address. As we have registered an IpV6 @ in the boundHandles Map, with the SocketAddress as a key, we *never* find back the bindAddress, as it's a IPV4 SocketAddress.

We have to find a way to use a key which is not IPV4/IPV6 sensible ...

> Session Idle events never comes in sessions managed by NioDatagramAcceptor
> --------------------------------------------------------------------------
>
>                 Key: DIRMINA-732
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-732
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M6
>         Environment: Any
>            Reporter: Mykhailo Tiutin
>            Priority: Minor
>             Fix For: 2.0.0-RC2
>
>         Attachments: DatagramSessionIdleTest.java, DatagramSessionIdleTimePatch
>
>
> Idle events never appears in sessions managed by NioDatagramAcceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DIRMINA-732) Session Idle events never comes in sessions managed by NioDatagramAcceptor

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny updated DIRMINA-732:
--------------------------------------

    Fix Version/s: 2.0.0-RC2

> Session Idle events never comes in sessions managed by NioDatagramAcceptor
> --------------------------------------------------------------------------
>
>                 Key: DIRMINA-732
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-732
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M6
>         Environment: Any
>            Reporter: Mykhailo Tiutin
>            Priority: Minor
>             Fix For: 2.0.0-RC2
>
>         Attachments: DatagramSessionIdleTest.java, DatagramSessionIdleTimePatch
>
>
> Idle events never appears in sessions managed by NioDatagramAcceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DIRMINA-732) Session Idle events never comes in sessions managed by NioDatagramAcceptor

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny resolved DIRMINA-732.
---------------------------------------

    Resolution: Fixed

Another patch is possible...

http://svn.apache.org/viewvc?rev=909179&view=rev

It's not really better.

The problem is that we are trying to compare IPV4 and IPV6 addresses. We should find a better way to build a key based on an address.

Please fell free to propose something better !

> Session Idle events never comes in sessions managed by NioDatagramAcceptor
> --------------------------------------------------------------------------
>
>                 Key: DIRMINA-732
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-732
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M6
>         Environment: Any
>            Reporter: Mykhailo Tiutin
>            Priority: Minor
>             Fix For: 2.0.0-RC2
>
>         Attachments: DatagramSessionIdleTest.java, DatagramSessionIdleTimePatch
>
>
> Idle events never appears in sessions managed by NioDatagramAcceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DIRMINA-732) Session Idle events never comes in sessions managed by NioDatagramAcceptor

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny closed DIRMINA-732.
-------------------------------------


> Session Idle events never comes in sessions managed by NioDatagramAcceptor
> --------------------------------------------------------------------------
>
>                 Key: DIRMINA-732
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-732
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M6
>         Environment: Any
>            Reporter: Mykhailo Tiutin
>            Priority: Minor
>             Fix For: 2.0.0-RC2
>
>         Attachments: DatagramSessionIdleTest.java, DatagramSessionIdleTimePatch
>
>
> Idle events never appears in sessions managed by NioDatagramAcceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DIRMINA-732) Session Idle events never comes in sessions managed by NioDatagramAcceptor

Posted by "Mykhailo Tiutin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mykhailo Tiutin updated DIRMINA-732:
------------------------------------

    Attachment: DatagramSessionIdleTest.java
                DatagramSessionIdleTimePatch

JUnit test and Patch provided

> Session Idle events never comes in sessions managed by NioDatagramAcceptor
> --------------------------------------------------------------------------
>
>                 Key: DIRMINA-732
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-732
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-M6
>         Environment: Any
>            Reporter: Mykhailo Tiutin
>            Priority: Minor
>         Attachments: DatagramSessionIdleTest.java, DatagramSessionIdleTimePatch
>
>
> Idle events never appears in sessions managed by NioDatagramAcceptor.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.