You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/08/03 10:07:09 UTC

[GitHub] [servicecomb-service-center] tianxiaoliang opened a new pull request, #1323: refactor policy validator

tianxiaoliang opened a new pull request, #1323:
URL: https://github.com/apache/servicecomb-service-center/pull/1323

   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    - [ ] Never comment source code, delete it.
    - [ ] UT should has "context, subject, expected result" result as test case name, when you call t.Run().
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] tianxiaoliang commented on a diff in pull request #1323: refactor policy validator

Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on code in PR #1323:
URL: https://github.com/apache/servicecomb-service-center/pull/1323#discussion_r939988185


##########
server/bootstrap/bootstrap.go:
##########
@@ -60,7 +60,8 @@ import (
 	_ "github.com/apache/servicecomb-service-center/server/rest/admin"
 
 	//governance
-	_ "github.com/apache/servicecomb-service-center/server/service/gov/kie"
+	_ "github.com/apache/servicecomb-service-center/server/ext/policy"
+	_ "github.com/apache/servicecomb-service-center/server/service/grc/kie"

Review Comment:
   rest api已经路径是gov了，考虑还是一致，但是能力层，还是取了个正宗的英文缩写



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] tianxiaoliang commented on a diff in pull request #1323: refactor policy validator

Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on code in PR #1323:
URL: https://github.com/apache/servicecomb-service-center/pull/1323#discussion_r939987639


##########
server/ext/policy/buitin.go:
##########
@@ -0,0 +1,51 @@
+package policy
+
+import (
+	"github.com/apache/servicecomb-service-center/server/service/grc"
+	"k8s.io/kube-openapi/pkg/validation/spec"
+)
+
+func init() {
+	grc.RegisterPolicySchema("loadbalancer", &spec.Schema{

Review Comment:
   server/service/grc/validate.go  走的老逻辑



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] tianxiaoliang commented on a diff in pull request #1323: refactor policy validator

Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on code in PR #1323:
URL: https://github.com/apache/servicecomb-service-center/pull/1323#discussion_r939979379


##########
server/ext/policy/buitin.go:
##########
@@ -0,0 +1,51 @@
+package policy
+
+import (
+	"github.com/apache/servicecomb-service-center/server/service/grc"
+	"k8s.io/kube-openapi/pkg/validation/spec"
+)
+
+func init() {
+	grc.RegisterPolicySchema("loadbalancer", &spec.Schema{
+		SchemaProps: spec.SchemaProps{
+			Type:     []string{"object"},
+			Required: []string{"rule"},
+			Properties: map[string]spec.Schema{
+				"rule": {
+					SchemaProps: spec.SchemaProps{Type: []string{"string"}}},
+			},
+		}})
+	grc.RegisterPolicySchema("circuitBreaker", &spec.Schema{

Review Comment:
   其实也可以。我开放open api后，就可以拿json格式提交了



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] little-cui merged pull request #1323: refactor policy validator

Posted by GitBox <gi...@apache.org>.
little-cui merged PR #1323:
URL: https://github.com/apache/servicecomb-service-center/pull/1323


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] little-cui commented on a diff in pull request #1323: refactor policy validator

Posted by GitBox <gi...@apache.org>.
little-cui commented on code in PR #1323:
URL: https://github.com/apache/servicecomb-service-center/pull/1323#discussion_r939976285


##########
server/ext/policy/buitin.go:
##########
@@ -0,0 +1,51 @@
+package policy
+
+import (
+	"github.com/apache/servicecomb-service-center/server/service/grc"
+	"k8s.io/kube-openapi/pkg/validation/spec"
+)
+
+func init() {
+	grc.RegisterPolicySchema("loadbalancer", &spec.Schema{

Review Comment:
   少了ratelimiting和retry



##########
server/bootstrap/bootstrap.go:
##########
@@ -60,7 +60,8 @@ import (
 	_ "github.com/apache/servicecomb-service-center/server/rest/admin"
 
 	//governance
-	_ "github.com/apache/servicecomb-service-center/server/service/gov/kie"
+	_ "github.com/apache/servicecomb-service-center/server/ext/policy"
+	_ "github.com/apache/servicecomb-service-center/server/service/grc/kie"

Review Comment:
   resource层也统一叫grc吧



##########
server/ext/policy/buitin.go:
##########
@@ -0,0 +1,51 @@
+package policy
+
+import (
+	"github.com/apache/servicecomb-service-center/server/service/grc"
+	"k8s.io/kube-openapi/pkg/validation/spec"
+)
+
+func init() {
+	grc.RegisterPolicySchema("loadbalancer", &spec.Schema{
+		SchemaProps: spec.SchemaProps{
+			Type:     []string{"object"},
+			Required: []string{"rule"},
+			Properties: map[string]spec.Schema{
+				"rule": {
+					SchemaProps: spec.SchemaProps{Type: []string{"string"}}},
+			},
+		}})
+	grc.RegisterPolicySchema("circuitBreaker", &spec.Schema{

Review Comment:
   这些能用yaml配置描述吗



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org