You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Matt <mi...@gmail.com> on 2016/01/12 04:14:21 UTC
Review Request 42179: Stack Advisor should display warning when PXF
component not collocated with NAMENODE and DATANODE
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42179/
-----------------------------------------------------------
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Lav Jain, Newton Alex, and Oleksandr Diachenko.
Bugs: AMBARI-14622
https://issues.apache.org/jira/browse/AMBARI-14622
Repository: ambari
Description
-------
Stack Advisor should display warning when PXF component not collocated with NAMENODE and DATANODE
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 0da566b
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 7a8d8ce
Diff: https://reviews.apache.org/r/42179/diff/
Testing
-------
Tested manually.
Added unit tests.
Unit tests passed for HDP23StackAdvisor
Thanks,
Matt
Re: Review Request 42179: Stack Advisor should display warning when
PXF component not collocated with NAMENODE and DATANODE
Posted by Matt <mi...@gmail.com>.
> On Jan. 11, 2016, 9:14 p.m., bhuvnesh chaudhary wrote:
> > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py, line 215
> > <https://reviews.apache.org/r/42179/diff/1/?file=1192907#file1192907line215>
> >
> > minor, but you could have probably used a function similar to __gethost() here as well to avoid the duplication.
Updating patch
- Matt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42179/#review113935
-----------------------------------------------------------
On Jan. 11, 2016, 7:14 p.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42179/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 7:14 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Lav Jain, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-14622
> https://issues.apache.org/jira/browse/AMBARI-14622
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Stack Advisor should display warning when PXF component not collocated with NAMENODE and DATANODE
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 0da566b
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 7a8d8ce
>
> Diff: https://reviews.apache.org/r/42179/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
> Added unit tests.
>
> Unit tests passed for HDP23StackAdvisor
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 42179: Stack Advisor should display warning when
PXF component not collocated with NAMENODE and DATANODE
Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42179/#review113935
-----------------------------------------------------------
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py (line 215)
<https://reviews.apache.org/r/42179/#comment174719>
minor, but you could have probably used a function similar to __gethost() here as well to avoid the duplication.
- bhuvnesh chaudhary
On Jan. 12, 2016, 3:14 a.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42179/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 3:14 a.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Lav Jain, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-14622
> https://issues.apache.org/jira/browse/AMBARI-14622
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Stack Advisor should display warning when PXF component not collocated with NAMENODE and DATANODE
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 0da566b
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 7a8d8ce
>
> Diff: https://reviews.apache.org/r/42179/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
> Added unit tests.
>
> Unit tests passed for HDP23StackAdvisor
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 42179: Stack Advisor should display warning when
PXF component not collocated with NAMENODE and DATANODE
Posted by Oleksandr Diachenko <od...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42179/#review114080
-----------------------------------------------------------
Ship it!
Ship It!
- Oleksandr Diachenko
On Jan. 12, 2016, 6:02 a.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42179/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 6:02 a.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Lav Jain, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-14622
> https://issues.apache.org/jira/browse/AMBARI-14622
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Stack Advisor should display warning when PXF component not collocated with NAMENODE and DATANODE
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 0da566b
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 7a8d8ce
>
> Diff: https://reviews.apache.org/r/42179/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
> Added unit tests.
>
> Unit tests passed for HDP23StackAdvisor
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 42179: Stack Advisor should display warning when
PXF component not collocated with NAMENODE and DATANODE
Posted by Lav Jain <lj...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42179/#review114007
-----------------------------------------------------------
Ship it!
Ship It!
- Lav Jain
On Jan. 12, 2016, 6:02 a.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42179/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 6:02 a.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Lav Jain, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-14622
> https://issues.apache.org/jira/browse/AMBARI-14622
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Stack Advisor should display warning when PXF component not collocated with NAMENODE and DATANODE
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 0da566b
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 7a8d8ce
>
> Diff: https://reviews.apache.org/r/42179/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
> Added unit tests.
>
> Unit tests passed for HDP23StackAdvisor
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request 42179: Stack Advisor should display warning when
PXF component not collocated with NAMENODE and DATANODE
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42179/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 10:02 p.m.)
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Lav Jain, Newton Alex, and Oleksandr Diachenko.
Changes
-------
Updating tests
Bugs: AMBARI-14622
https://issues.apache.org/jira/browse/AMBARI-14622
Repository: ambari
Description
-------
Stack Advisor should display warning when PXF component not collocated with NAMENODE and DATANODE
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 0da566b
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 7a8d8ce
Diff: https://reviews.apache.org/r/42179/diff/
Testing
-------
Tested manually.
Added unit tests.
Unit tests passed for HDP23StackAdvisor
Thanks,
Matt