You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Liam Ryan (JIRA)" <ji...@apache.org> on 2018/04/17 22:43:00 UTC
[jira] [Comment Edited] (CB-14036) source-file or resource-file png
in plugin.xml breaks subsequent plugins for cordova-android 7
[ https://issues.apache.org/jira/browse/CB-14036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441614#comment-16441614 ]
Liam Ryan edited comment on CB-14036 at 4/17/18 10:42 PM:
----------------------------------------------------------
As I said I did try with resource-file. The attached plugin.xml will fail in the same manner, however if you comment out the resource-file line ( line 49 ) it will work as expected.
I have tried with both target-dir="res/drawable-hdpi/" and target=dir="res/drawable-hdpi/ic_fp_40px.png" as in the attached plugin.
I apologize if I'm missing something trivial here but since both source-file and resource-file are causing this issue, and I copied the format of resource-file from the plugin you suggested, I believe there is an issue.
Here's a branch which has this plugin and some test code. If you run npm install && cordova platform add android after replacing the plugin.xml for fingerprint-aio plugin you should be able to reproduce - [https://github.com/Liam-Ryan/ionic-cordova-android-7/tree/fingerprint-aio]
If you want I can also provide a branch of fingerprint-aio with the modified plugin.xml already included tomorrow
was (Author: nessus):
As I said I did try with resource-file. The attached plugin.xml will fail in the same manner, however if you comment out the resource-file line ( line 49 ) it will work as expected.
I have tried with both target-dir="res/drawable-hdpi/" and target=dir="res/drawable-hdpi/ic_fp_40px.png" as in the attached plugin.
I apologize if I'm missing something trivial here but since both source-file and resource-file are causing this issue, and I copied the format of resource-file from the plugin you suggested, I believe there is an issue.
Here's a branch which has this plugin and some test code. If you run npm install && cordova platform add android you should be able to reproduce - [https://github.com/Liam-Ryan/ionic-cordova-android-7/tree/fingerprint-aio]
> source-file or resource-file png in plugin.xml breaks subsequent plugins for cordova-android 7
> ----------------------------------------------------------------------------------------------
>
> Key: CB-14036
> URL: https://issues.apache.org/jira/browse/CB-14036
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
> Affects Versions: 7.0.0
> Environment: This is the blank project that I build together with environment ( pasted below for reference ) - [https://github.com/Liam-Ryan/ionic-cordova-android-7]
>
> After setting up this project running ionic cordova plugin add cordova-plugin-fingerprint-aio && cordova platform add android will reproduce the issue.
>
> {{cli packages: @ionic/cli-utils : 1.19.2 }}
> {{ionic (Ionic CLI) : 3.20.0 }}
> {{global packages: cordova (Cordova CLI) : 8.0.0 }}
> {{local packages: @ionic/app-scripts : 3.1.8 }}
> {{Cordova Platforms : android 7.0.0 }}
> {{Ionic Framework : ionic-angular 3.9.2 }}
> {{System: Android SDK Tools : 26.1.1 Node : v8.10.0 }}
> {{npm : 5.6.0 }}
> {{OS : Windows 7 Cordova 8.0.0}}
>
> Reporter: Liam Ryan
> Assignee: Joe Bowser
> Priority: Major
> Attachments: plugin.xml
>
>
> Plugin.xml for cordova-plugin-fingerprint-aio contains tags like the following. I have also tried changing to resource-file. When these tags are present in either form then subsequent plugins seem to revert to the old cordova-android directory structure which causes their installation to fail during cordova platform add android and also hides the cause of the issue since there are no errors for the plugin containing these tags
> {{<source-file src="res/android/drawable-hdpi/ic_fp_40px.png" target-dir="res/drawable-hdpi"/>}}
>
> {{The same tag for copying xml files works with no issues and no effect on subsequent plugins}}
>
> {{Example of error - Failed to install 'cordova-plugin-splashscreen': Error: ENOENT: no such file or directory, open 'E:\Development\Angular2\Cordova7\cordova7\platforms\android\AndroidManifest.xml'}}
>
> {{I'm building with latest ionic blank project ( see environment ) and the plugin in question is cordova-plugin-fingerprint-aio. I'm aware that this project is not yet cordova-android 7 compliant, I'm trying to create a pull request for same }}
>
> [https://github.com/NiklasMerz/cordova-plugin-fingerprint-aio/pull/94]
>
> This is the blank project that I build together with environment ( pasted below for reference ) - [https://github.com/Liam-Ryan/ionic-cordova-android-7]
>
> After setting up this project running ionic cordova plugin add cordova-plugin-fingerprint-aio && cordova platform add android will reproduce the issue.
>
> {{cli packages: @ionic/cli-utils : 1.19.2}}
> {{ionic (Ionic CLI) : 3.20.0}}
> {{global packages: cordova (Cordova CLI) : 8.0.0}}
> {{local packages: @ionic/app-scripts : 3.1.8}}
> {{Cordova Platforms : android 7.0.0}}
> {{Ionic Framework : ionic-angular 3.9.2}}
> {{System: Android SDK Tools : 26.1.1 Node : v8.10.0}}
> {{npm : 5.6.0}}
> {{OS : Windows 7 Cordova 8.0.0}}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org