You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/20 11:52:52 UTC
[GitHub] [skywalking] heyanlong opened a new pull request #4547: Add PHP
module support to e2e test
heyanlong opened a new pull request #4547: Add PHP module support to e2e test
URL: https://github.com/apache/skywalking/pull/4547
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
Add PHP module support to e2e test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] heyanlong commented on issue #4547: Add PHP module
support to e2e test
Posted by GitBox <gi...@apache.org>.
heyanlong commented on issue #4547: Add PHP module support to e2e test
URL: https://github.com/apache/skywalking/pull/4547#issuecomment-602010496
@wu-sheng Added in CI control file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4547: Add PHP
module support to e2e test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4547: Add PHP module support to e2e test
URL: https://github.com/apache/skywalking/pull/4547#issuecomment-601677507
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=h1) Report
> Merging [#4547](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/2e9f0016332ec4d3d79393897c7985eda2376fd6?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4547 +/- ##
=======================================
Coverage 25.55% 25.55%
=======================================
Files 1245 1245
Lines 28961 28961
Branches 3973 3973
=======================================
Hits 7402 7402
Misses 20869 20869
Partials 690 690
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=footer). Last update [2e9f001...544200e](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4547: Add PHP module support to e2e test
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4547: Add PHP module support to e2e test
URL: https://github.com/apache/skywalking/pull/4547#discussion_r395647306
##########
File path: test/e2e/e2e-test/docker/php/docker-compose.yml
##########
@@ -0,0 +1,86 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: '2.1'
+
+services:
+ oap:
+ image: skywalking/oap:latest
+ expose:
+ - 11800
+ - 12800
+ networks:
+ - e2e
+ restart: on-failure
+ healthcheck:
+ test: ["CMD", "bash", "-c", "cat < /dev/null > /dev/tcp/127.0.0.1/11800"]
+ interval: 5s
+ timeout: 60s
+ retries: 120
+
+ php:
+ image: skyapm/skywalking-php:latest
+ networks:
+ e2e:
+ aliases:
+ - php
+ expose:
+ - 8080
+ environment:
+ - SW_AGENT_COLLECTOR_BACKEND_SERVICES=oap:11800
+ depends_on:
+ oap:
+ condition: service_healthy
+ volumes:
+ - ../php/index.php:/opt/www/index.php
+ - ../php/php.ini:/usr/local/etc/php/conf.d/ext-skywalking.ini
+
+ php-shadow:
+ image: skyapm/skywalking-php:latest
+ networks:
+ e2e:
+ aliases:
+ - php-shadow
Review comment:
do we need an alias? if not, let's make it minimal simple
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4547: Add PHP module
support to e2e test
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4547: Add PHP module support to e2e test
URL: https://github.com/apache/skywalking/pull/4547#issuecomment-601701884
I think you never add your e2e test into the CI control file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4547: Add PHP
module support to e2e test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4547: Add PHP module support to e2e test
URL: https://github.com/apache/skywalking/pull/4547#issuecomment-601677507
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=h1) Report
> Merging [#4547](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/2e9f0016332ec4d3d79393897c7985eda2376fd6?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4547 +/- ##
=======================================
Coverage 25.55% 25.55%
=======================================
Files 1245 1245
Lines 28961 28961
Branches 3973 3973
=======================================
Hits 7402 7402
Misses 20869 20869
Partials 690 690
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=footer). Last update [2e9f001...544200e](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4547: Add PHP module support to e2e test
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4547: Add PHP module support to e2e test
URL: https://github.com/apache/skywalking/pull/4547#discussion_r395647396
##########
File path: test/e2e/e2e-test/docker/php/docker-compose.yml
##########
@@ -0,0 +1,86 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: '2.1'
+
+services:
+ oap:
+ image: skywalking/oap:latest
+ expose:
+ - 11800
+ - 12800
+ networks:
+ - e2e
+ restart: on-failure
+ healthcheck:
+ test: ["CMD", "bash", "-c", "cat < /dev/null > /dev/tcp/127.0.0.1/11800"]
+ interval: 5s
+ timeout: 60s
+ retries: 120
+
+ php:
+ image: skyapm/skywalking-php:latest
+ networks:
+ e2e:
+ aliases:
+ - php
+ expose:
+ - 8080
+ environment:
+ - SW_AGENT_COLLECTOR_BACKEND_SERVICES=oap:11800
+ depends_on:
+ oap:
+ condition: service_healthy
+ volumes:
+ - ../php/index.php:/opt/www/index.php
+ - ../php/php.ini:/usr/local/etc/php/conf.d/ext-skywalking.ini
Review comment:
```suggestion
- ./index.php:/opt/www/index.php
- ./php.ini:/usr/local/etc/php/conf.d/ext-skywalking.ini
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 merged pull request #4547: Add PHP module
support to e2e test
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4547: Add PHP module support to e2e test
URL: https://github.com/apache/skywalking/pull/4547
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4547: Add PHP module
support to e2e test
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4547: Add PHP module support to e2e test
URL: https://github.com/apache/skywalking/pull/4547#issuecomment-601702199
Ping me about your Docker Hub account, I could add you into the skyapm manager group.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4547: Add PHP module
support to e2e test
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4547: Add PHP module support to e2e test
URL: https://github.com/apache/skywalking/pull/4547#issuecomment-601677507
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=h1) Report
> Merging [#4547](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/5251cc7239d184d3b72069373cd83a3cb84e7482&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4547 +/- ##
==========================================
- Coverage 25.55% 25.53% -0.03%
==========================================
Files 1245 1245
Lines 28961 28961
Branches 3973 3973
==========================================
- Hits 7402 7394 -8
- Misses 20869 20876 +7
- Partials 690 691 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4547/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4547/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `24.73% <0.00%> (-1.08%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=footer). Last update [5251cc7...492de58](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4547: Add PHP module support to e2e test
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4547: Add PHP module support to e2e test
URL: https://github.com/apache/skywalking/pull/4547#discussion_r396091661
##########
File path: .github/workflows/e2e.yaml
##########
@@ -80,6 +80,28 @@ jobs:
name: logs
path: logs
+ FeatureGroup03:
Review comment:
> @kezhenxu94 I have a doubt about the group naming principle. What are they? Why all these say `FeatureGroupxx`, and the last one shows `Gateway`?
The `Gateway` should be also renamed to `FeatureGroupXX` I think, if @wu-sheng you have better suggestion, I'm good to follow :) as for the `PHP` job, as an individual language agent, I prefer to set up another workflow, named `PHP Agent` or `PHP SDK`, WDYT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4547: Add PHP module support to e2e test
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4547: Add PHP module support to e2e test
URL: https://github.com/apache/skywalking/pull/4547#discussion_r395646826
##########
File path: test/e2e/e2e-test/docker/php/docker-compose.yml
##########
@@ -0,0 +1,86 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: '2.1'
+
+services:
+ oap:
+ image: skywalking/oap:latest
+ expose:
+ - 11800
+ - 12800
+ networks:
+ - e2e
+ restart: on-failure
+ healthcheck:
+ test: ["CMD", "bash", "-c", "cat < /dev/null > /dev/tcp/127.0.0.1/11800"]
+ interval: 5s
+ timeout: 60s
+ retries: 120
+
+ php:
+ image: skyapm/skywalking-php:latest
+ networks:
+ e2e:
+ aliases:
+ - php
+ expose:
+ - 8080
+ environment:
+ - SW_AGENT_COLLECTOR_BACKEND_SERVICES=oap:11800
+ depends_on:
+ oap:
+ condition: service_healthy
+ volumes:
+ - ../php/index.php:/opt/www/index.php
+ - ../php/php.ini:/usr/local/etc/php/conf.d/ext-skywalking.ini
+
+ php-shadow:
+ image: skyapm/skywalking-php:latest
+ networks:
+ e2e:
+ aliases:
+ - php-shadow
+ expose:
+ - 8080
+ environment:
+ - SW_AGENT_COLLECTOR_BACKEND_SERVICES=oap:11800
+ depends_on:
+ php:
+ condition: service_started
+ oap:
+ condition: service_healthy
+ volumes:
+ - ../php/index.php:/opt/www/index.php
+ - ../php/php-shadow.ini:/usr/local/etc/php/conf.d/ext-skywalking.ini
Review comment:
```suggestion
- ./index.php:/opt/www/index.php
- ./php-shadow.ini:/usr/local/etc/php/conf.d/ext-skywalking.ini
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4547: Add PHP
module support to e2e test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4547: Add PHP module support to e2e test
URL: https://github.com/apache/skywalking/pull/4547#issuecomment-601677507
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=h1) Report
> Merging [#4547](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/2e9f0016332ec4d3d79393897c7985eda2376fd6&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4547 +/- ##
=======================================
Coverage 25.55% 25.55%
=======================================
Files 1245 1245
Lines 28961 28961
Branches 3973 3973
=======================================
Hits 7402 7402
Misses 20869 20869
Partials 690 690
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=footer). Last update [2e9f001...8eddc66](https://codecov.io/gh/apache/skywalking/pull/4547?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4547: Add PHP module support to e2e test
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4547: Add PHP module support to e2e test
URL: https://github.com/apache/skywalking/pull/4547#discussion_r395647769
##########
File path: test/e2e/e2e-test/docker/php/docker-compose.yml
##########
@@ -0,0 +1,86 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: '2.1'
+
+services:
+ oap:
+ image: skywalking/oap:latest
+ expose:
+ - 11800
+ - 12800
+ networks:
+ - e2e
+ restart: on-failure
+ healthcheck:
+ test: ["CMD", "bash", "-c", "cat < /dev/null > /dev/tcp/127.0.0.1/11800"]
+ interval: 5s
+ timeout: 60s
+ retries: 120
+
+ php:
+ image: skyapm/skywalking-php:latest
+ networks:
+ e2e:
+ aliases:
+ - php
Review comment:
remove if we don't need it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4547:
Add PHP module support to e2e test
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4547: Add PHP module support to e2e test
URL: https://github.com/apache/skywalking/pull/4547#discussion_r396091932
##########
File path: .github/workflows/e2e.yaml
##########
@@ -80,6 +80,28 @@ jobs:
name: logs
path: logs
+ FeatureGroup03:
Review comment:
I prefer it keeps in a separated group, to avoid unexpected CI process conflict with other tests. Also, most PMC know little about the PHP agent, if conflict occurs, it is hard to follow.
@heyanlong Please create `e2e.php.yaml`.
@kezhenxu94 , please rename to `FeatureGroupXX`, at least keep consistent. I don't have better idea for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4547:
Add PHP module support to e2e test
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4547: Add PHP module support to e2e test
URL: https://github.com/apache/skywalking/pull/4547#discussion_r396089656
##########
File path: .github/workflows/e2e.yaml
##########
@@ -80,6 +80,28 @@ jobs:
name: logs
path: logs
+ FeatureGroup03:
Review comment:
@kezhenxu94 I have a doubt about the group naming principle. What are they? Why all these say `FeatureGroupxx`, and the last one shows `Gateway`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4547:
Add PHP module support to e2e test
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4547: Add PHP module support to e2e test
URL: https://github.com/apache/skywalking/pull/4547#discussion_r396247788
##########
File path: test/e2e/e2e-test/docker/php/docker-compose.yml
##########
@@ -0,0 +1,82 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: '2.1'
+
+services:
+ oap:
+ image: skywalking/oap:latest
+ expose:
+ - 11800
+ - 12800
+ networks:
+ - e2e
+ restart: on-failure
+ healthcheck:
+ test: ["CMD", "bash", "-c", "cat < /dev/null > /dev/tcp/127.0.0.1/11800"]
+ interval: 5s
+ timeout: 60s
+ retries: 120
+
+ php-shadow:
+ image: skyapm/skywalking-php:latest
Review comment:
I highly recommended don't use `latest`. Let's image what will happen in the next release? If something breaks in there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services