You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openjpa.apache.org by jr...@apache.org on 2013/05/13 03:31:42 UTC
svn commit: r1481680 -
/openjpa/branches/1.2.x/openjpa-lib/src/main/java/org/apache/openjpa/lib/conf/PluginValue.java
Author: jrbauer
Date: Mon May 13 01:31:41 2013
New Revision: 1481680
URL: http://svn.apache.org/r1481680
Log:
Refrain from logging if verifying log factory plugin.
Modified:
openjpa/branches/1.2.x/openjpa-lib/src/main/java/org/apache/openjpa/lib/conf/PluginValue.java
Modified: openjpa/branches/1.2.x/openjpa-lib/src/main/java/org/apache/openjpa/lib/conf/PluginValue.java
URL: http://svn.apache.org/viewvc/openjpa/branches/1.2.x/openjpa-lib/src/main/java/org/apache/openjpa/lib/conf/PluginValue.java?rev=1481680&r1=1481679&r2=1481680&view=diff
==============================================================================
--- openjpa/branches/1.2.x/openjpa-lib/src/main/java/org/apache/openjpa/lib/conf/PluginValue.java (original)
+++ openjpa/branches/1.2.x/openjpa-lib/src/main/java/org/apache/openjpa/lib/conf/PluginValue.java Mon May 13 01:31:41 2013
@@ -20,6 +20,7 @@ package org.apache.openjpa.lib.conf;
import org.apache.commons.lang.StringUtils;
import org.apache.openjpa.lib.log.Log;
+import org.apache.openjpa.lib.log.LogFactory;
import org.apache.openjpa.lib.util.Localizer;
import org.apache.openjpa.lib.util.ParseException;
@@ -105,7 +106,8 @@ public class PluginValue extends ObjectV
// ensure plugin value is compatible with plugin type
if (obj != null && !type.isAssignableFrom(obj.getClass())) {
- Log log = (conf == null) ? null : conf.getConfigurationLog();
+ Log log = (conf == null || type.equals(LogFactory.class))
+ ? null : conf.getConfigurationLog();
String msg = getIncompatiblePluginMessage(obj, type);
if (log != null && log.isErrorEnabled()) {
log.error(msg);