You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/03/26 12:53:51 UTC
[GitHub] [incubator-mxnet] perdasilva opened a new pull request #14527:
Fixes hidden gpu test failure
perdasilva opened a new pull request #14527: Fixes hidden gpu test failure
URL: https://github.com/apache/incubator-mxnet/pull/14527
## Description ##
The way CI is at the moment, some failing GPU tests are going undetected. I'm putting together a PR (#14513) to update CI do CUDA v10 and fix a bug in the way the cuDNN version gets used in the tests.
In this PR, I fix one such failing test introduced in PR #14219, where the function signature for `check_rnn_layer_forward` was changed and a context parameter added with a default value of mx.cpu().
The [test_lstmp](https://github.com/apache/incubator-mxnet/blob/master/tests/python/gpu/test_gluon_gpu.py#L86) test fails because it uses the `check_rnn_layer_forward` function without setting the context to mx.gpu(0).
In this PR, I remove the default value to force the user to set the context. Thus avoiding such errors in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services