You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (JIRA)" <ji...@apache.org> on 2018/02/12 17:41:00 UTC
[jira] [Commented] (SOLR-11898) ConcurrentModificationException
when calling
org.apache.solr.core.SolrInfoBean.getMetricsSnapshot(SolrInfoBean.java:62)
[ https://issues.apache.org/jira/browse/SOLR-11898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361144#comment-16361144 ]
Erick Erickson commented on SOLR-11898:
---------------------------------------
LGTM, I'm testing now. [~ab] since you've been in the metrics code a lot, do you have any comments?
> ConcurrentModificationException when calling org.apache.solr.core.SolrInfoBean.getMetricsSnapshot(SolrInfoBean.java:62)
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-11898
> URL: https://issues.apache.org/jira/browse/SOLR-11898
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Affects Versions: 7.1
> Reporter: Jeff Miller
> Assignee: Erick Erickson
> Priority: Major
> Labels: newbie
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> SOLR-11255 Updated to use ConcurrentHashMap.newKeySet(); for all metricNames implementation but missed a few classes.
> I see this exception happening once in a while:
> Cause0: java.util.ConcurrentModificationException Cause0-StackTrace: at java.util.HashMap$KeySpliterator.forEachRemaining(HashMap.java:1558) at java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:580) at org.apache.solr.util.stats.MetricUtils.convertMetrics(MetricUtils.java:248) at org.apache.solr.util.stats.MetricUtils.convertMetrics(MetricUtils.java:226) at org.apache.solr.core.SolrInfoBean.getMetricsSnapshot(SolrInfoBean.java:62)
>
> Three classes weren't updated from using a HashSet for metricNames: FastLRUCache, LFUCache and LRUCache
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org