You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tvm.apache.org by Tianqi Chen <no...@github.com.INVALID> on 2023/01/08 17:16:41 UTC

[apache/tvm-rfcs] [RFC] Further Unify Packed and Object in TVM Runtime (PR #97)

You can view, comment on, or merge this pull request online at:

  https://github.com/apache/tvm-rfcs/pull/97

-- Commit Summary --

  * Add RFC unify packed and object

-- File Changes --

    A rfcs/0097-unify-packed-and-object.md (678)

-- Patch Links --

https://github.com/apache/tvm-rfcs/pull/97.patch
https://github.com/apache/tvm-rfcs/pull/97.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/97
You are receiving this because you are subscribed to this thread.

Message ID: &lt;apache/tvm-rfcs/pull/97@github.com&gt;

Re: [apache/tvm-rfcs] [RFC] Further Unify Packed and Object in TVM Runtime (PR #97)

Posted by Tianqi Chen <no...@github.com.INVALID>.

cc @apache/tvm-committers for visibility

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/97#issuecomment-1374885576
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/tvm-rfcs] [RFC] Further Unify Packed and Object in TVM Runtime (PR #97)

Posted by Siyuan Feng <no...@github.com.INVALID>.

Thanks for everyone's input. We are going to merge in 24 hours if there are no additional comments.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/97#issuecomment-1445703012
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/tvm-rfcs] [RFC] Further Unify Packed and Object in TVM Runtime (PR #97)

Posted by Siyuan Feng <no...@github.com.INVALID>.

The comments so far seem have been addressed, would love to see if we have additional comments, and move forward on this

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/97#issuecomment-1431459868
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/tvm-rfcs] [RFC] Further Unify Packed and Object in TVM Runtime (PR #97)

Posted by Siyuan Feng <no...@github.com.INVALID>.

Merged #97 into main.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/97#event-8624055152
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/tvm-rfcs] [RFC] Further Unify Packed and Object in TVM Runtime (PR #97)

Posted by Tianqi Chen <no...@github.com.INVALID>.

ping @Mousius @leandron 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/97#issuecomment-1416781602
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/tvm-rfcs] [RFC] Further Unify Packed and Object in TVM Runtime (PR #97)

Posted by Christopher Sidebottom <no...@github.com.INVALID>.

@tqchen Ack. I'll take another look this week.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/97#issuecomment-1418746047
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/tvm-rfcs] [RFC] Further Unify Packed and Object in TVM Runtime (PR #97)

Posted by Tianqi Chen <no...@github.com.INVALID>.

@Mousius to specifically answer your questions on IntImm for bool and int. Likely this is due to the way we use container and checkers. Right now IntImm is indeed designed to hold for int and bool. And we will need to specific type checking on dtype which might be missed in such a case. Differentiating bool and int in the special section will likely resolve the issue if we believe it is important to have special casing for bool

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/97#issuecomment-1376047312
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/tvm-rfcs] [RFC] Further Unify Packed and Object in TVM Runtime (PR #97)

Posted by Tianqi Chen <no...@github.com.INVALID>.

Thanks @leandron @Mousius for helpful suggestions in readability, we have incorporated most of them.  We would like still keep discussions of prior work design(in this case matx) both in prior Art as well as in the section of respective context to give clarity and context for the reader (this is also a common practice in technical scientific writing). Also updated the text with more clarifications on some of the questions asked.




-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/97#issuecomment-1375844243
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/tvm-rfcs] [RFC] Further Unify Packed and Object in TVM Runtime (PR #97)

Posted by Tianqi Chen <no...@github.com.INVALID>.

@leandron @Mousius please take another look, i believe all the outstanding comments are addressed

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/97#issuecomment-1383162081
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>

Re: [apache/tvm-rfcs] [RFC] Further Unify Packed and Object in TVM Runtime (PR #97)

Posted by Siyuan Feng <no...@github.com.INVALID>.

This RFC is merged now. Thanks @tqchen for the proposal and the reviews from @leandron @Mousius @cyx-6 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/97#issuecomment-1447772441
You are receiving this because you are subscribed to this thread.

Message ID: <ap...@github.com>