You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/12/07 14:11:44 UTC
[GitHub] [incubator-kyuubi] turboFei opened a new issue, #3930: [TEST] KYUUBI #3839 session user sign - check session user sign *** FAILED ***
turboFei opened a new issue, #3930:
URL: https://github.com/apache/incubator-kyuubi/issues/3930
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues?q=is%3Aissue) and found no similar issues.
### What kind of test improve?
- [X] Fix flaky tests.
- [ ] Fix bug in tests.
- [ ] Increase test coverage.
- [ ] Other kinds of test improve.
### Describe the issues of the existing tests or improvements for new tests
```
- KYUUBI #3839 session user sign - check session user sign *** FAILED ***
java.lang.IllegalArgumentException: Illegal base64 character 2a
at java.base/java.util.Base64$Decoder.decode0(Base64.java:746)
at java.base/java.util.Base64$Decoder.decode(Base64.java:538)
at java.base/java.util.Base64$Decoder.decode(Base64.java:561)
at org.apache.kyuubi.util.SignUtils$.verifySignWithECDSA(SignUtils.scala:64)
at org.apache.kyuubi.session.SessionSigningSuite.$anonfun$new$10(SessionSigningSuite.scala:81)
at org.apache.kyuubi.session.SessionSigningSuite.$anonfun$new$10$adapted(SessionSigningSuite.scala:70)
at org.apache.kyuubi.operation.JDBCTestHelper.$anonfun$withMultipleConnectionJdbcStatement$3(JDBCTestHelper.scala:60)
at org.apache.kyuubi.operation.JDBCTestHelper.$anonfun$withMultipleConnectionJdbcStatement$3$adapted(JDBCTestHelper.scala:60)
at scala.collection.mutable.ResizableArray.foreach(ResizableArray.scala:62)
at scala.collection.mutable.ResizableArray.foreach$(ResizableArray.scala:55)
```
### Are you willing to submit PR?
- [ ] Yes. I can submit a PR independently to improve.
- [ ] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
- [ ] No. I cannot submit a PR at this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on issue #3930: [TEST] KYUUBI #3839 session user sign - check session user sign *** FAILED ***
Posted by GitBox <gi...@apache.org>.
turboFei commented on issue #3930:
URL: https://github.com/apache/incubator-kyuubi/issues/3930#issuecomment-1341026289
cc @bowenliang123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] bowenliang123 commented on issue #3930: [TEST] KYUUBI #3839 session user sign - check session user sign *** FAILED ***
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on issue #3930:
URL: https://github.com/apache/incubator-kyuubi/issues/3930#issuecomment-1341033156
Mark From pull https://github.com/apache/incubator-kyuubi/pull/3923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] bowenliang123 commented on issue #3930: [TEST] KYUUBI #3839 session user sign - check session user sign *** FAILED ***
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on issue #3930:
URL: https://github.com/apache/incubator-kyuubi/issues/3930#issuecomment-1341904991
cc @cfmcgrady
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on issue #3930: [TEST] KYUUBI #3839 session user sign - check session user sign *** FAILED ***
Posted by GitBox <gi...@apache.org>.
turboFei commented on issue #3930:
URL: https://github.com/apache/incubator-kyuubi/issues/3930#issuecomment-1341755068
As discussed offkine， you can check whether there's thread safe issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed issue #3930: [TEST] KYUUBI #3839 session user sign - check session user sign *** FAILED ***
Posted by GitBox <gi...@apache.org>.
ulysses-you closed issue #3930: [TEST] KYUUBI #3839 session user sign - check session user sign *** FAILED ***
URL: https://github.com/apache/incubator-kyuubi/issues/3930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on issue #3930: [TEST] KYUUBI #3839 session user sign - check session user sign *** FAILED ***
Posted by GitBox <gi...@apache.org>.
turboFei commented on issue #3930:
URL: https://github.com/apache/incubator-kyuubi/issues/3930#issuecomment-1341756327
Maybe similar with #2933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] bowenliang123 commented on issue #3930: [TEST] KYUUBI #3839 session user sign - check session user sign *** FAILED ***
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on issue #3930:
URL: https://github.com/apache/incubator-kyuubi/issues/3930#issuecomment-1341878406
Thanks for the reminder.
Let's check again. It also in ci runs of other ci runs (https://github.com/apache/incubator-kyuubi/actions/runs/3640665781/jobs/6145654539#step:6:1847)
In discussion in pull <https://github.com/apache/incubator-kyuubi/pull/3838>, @cfmcgrady mentioned about worries in thread safe problem. I listed several points,
1. key generation is on server side in singleton and never updated or shared
2. session key and user sign is generated when openSession, and put and passed in immutable confOverlay and never changed
3. Unlike in pull #2933, all there encoder and decoder
4. setting properties to SparkContext is to put value in a ThreadLocal prop holders, not sharing with other threads.
Possibley in ` #2933`, if `Signature.getInstance` in `SignUtils` not thread safe , it may cause problems.
But in exception message，`Illegal base64 character 2a` again puzzled me , the `2a` in hex (or 42 in decimal ) should be on the Base64 codec list.
So I will prefer by doing the following patch,
1. make `SignUtils.signWithPrivateKey` synchronized
2. show full string when base64 decoding failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org