You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "dannycjones (via GitHub)" <gi...@apache.org> on 2026/08/27 11:13:56 UTC

[PR] chore: Update MSRV to Rust 1.95 [iceberg-rust]

dannycjones opened a new pull request, #3083:
URL: https://github.com/apache/iceberg-rust/pull/3083

   ## Which issue does this PR close?
   
   Updates MSRV as part of release process for 0.11. Tracking for 0.11: #3034 
   
   ## What changes are included in this PR?
   
   Bump MSRV to 1.95, bump toolchain to the nightly at the time of 1.95 stable release.
   Address all new clippy and fmt findings to ensure code is compliant with rules enforced by continuous integration.
   
   Floats (32-bit) without the `_f32` suffix are now warnings as the behavior will be removed in a future compiler version. The suffix has been appended in this change.
   
   Initially, the MSRV was bumped to 1.96 however there appeared to be issues with respect to dead code detection. Thus, MSRV is only bumped to 1.95. Some changes from that were kept despite not necessarily blocking 1.95.
   
   ## Are these changes tested?
   
   N/A
   
   ## AI Disclosure
   
   AI was used to apply basic clippy fixes. All code is reviewed manually.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Update MSRV to Rust 1.95 [iceberg-rust]

Posted by "CTTY (via GitHub)" <gi...@apache.org>.
CTTY merged PR #3083:
URL: https://github.com/apache/iceberg-rust/pull/3083


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Update MSRV to Rust 1.95 [iceberg-rust]

Posted by "dannycjones (via GitHub)" <gi...@apache.org>.
dannycjones commented on PR #3083:
URL: https://github.com/apache/iceberg-rust/pull/3083#issuecomment-5440324626

   @CTTY would you be able to take a look at this one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Update MSRV to Rust 1.95 [iceberg-rust]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3083:
URL: https://github.com/apache/iceberg-rust/pull/3083#discussion_r3871283623


##########
crates/iceberg/src/spec/values/serde.rs:
##########
@@ -681,7 +681,7 @@ pub(crate) mod _serde {
                                     .ok_or_else(|| {
                                         invalid_err_with_reason(
                                             "record",
-                                            &format!("field {} is not exist", &field_name),
+                                            &format!("field {} is not exist", field_name),

Review Comment:
   The error message grammar is incorrect (\"is not exist\"). This is user-visible and should be changed to a clearer phrasing like \"field '{field_name}' does not exist\" (or similar), keeping the same information while improving readability.



##########
crates/iceberg/src/spec/manifest_list/mod.rs:
##########
@@ -196,7 +196,7 @@ mod test {
                     existing_rows_count: Some(0),
                     deleted_rows_count: Some(0),
                     partitions: Some(
-                        vec![FieldSummary { contains_null: false, contains_nan: Some(false), lower_bound: Some(Datum::float(1.1).to_bytes().unwrap()), upper_bound: Some(Datum::float(2.1).to_bytes().unwrap())}]
+                        vec![FieldSummary { contains_null: false, contains_nan: Some(false), lower_bound: Some(Datum::float(1.1_f32).to_bytes().unwrap()), upper_bound: Some(Datum::float(2.1_f32).to_bytes().unwrap())}]

Review Comment:
   This line is extremely long and hard to scan in reviews/debugging. Consider formatting the `FieldSummary` struct literal across multiple lines (and similarly for the other occurrence in this file) to improve readability and reduce future diff noise.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Update MSRV to Rust 1.95 [iceberg-rust]

Posted by "dannycjones (via GitHub)" <gi...@apache.org>.
dannycjones commented on code in PR #3083:
URL: https://github.com/apache/iceberg-rust/pull/3083#discussion_r3871913249


##########
crates/iceberg/src/spec/values/serde.rs:
##########
@@ -681,7 +681,7 @@ pub(crate) mod _serde {
                                     .ok_or_else(|| {
                                         invalid_err_with_reason(
                                             "record",
-                                            &format!("field {} is not exist", &field_name),
+                                            &format!("field {} is not exist", field_name),

Review Comment:
   Not changing this right now. Keeping it strictly MSRV-related.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] chore: Update MSRV to Rust 1.95 [iceberg-rust]

Posted by "dannycjones (via GitHub)" <gi...@apache.org>.
dannycjones commented on code in PR #3083:
URL: https://github.com/apache/iceberg-rust/pull/3083#discussion_r3871916426


##########
crates/iceberg/src/spec/manifest_list/mod.rs:
##########
@@ -196,7 +196,7 @@ mod test {
                     existing_rows_count: Some(0),
                     deleted_rows_count: Some(0),
                     partitions: Some(
-                        vec![FieldSummary { contains_null: false, contains_nan: Some(false), lower_bound: Some(Datum::float(1.1).to_bytes().unwrap()), upper_bound: Some(Datum::float(2.1).to_bytes().unwrap())}]
+                        vec![FieldSummary { contains_null: false, contains_nan: Some(false), lower_bound: Some(Datum::float(1.1_f32).to_bytes().unwrap()), upper_bound: Some(Datum::float(2.1_f32).to_bytes().unwrap())}]

Review Comment:
   I'm not changing this since it's not required, although it does surprise me that this passes `rustfmt`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org