You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/07/28 01:05:50 UTC
[GitHub] [zeppelin] kkoldduck2 opened a new pull request, #4437: Remove sap interpreter
kkoldduck2 opened a new pull request, #4437:
URL: https://github.com/apache/zeppelin/pull/4437
### What is this PR for?
Remove sap interpreter which is not used frequently
### What type of PR is it?
Refactoring
### Todos
* [ ] - Remove sap and related things
### What is the Jira issue?
[* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/](https://issues.apache.org/jira/browse/ZEPPELIN-5786?jql=labels%20%3D%20ossca2022)
### How should this be tested?
* CI
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need to update? Yes, Edited
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes, Edited
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] HYEEWON commented on a diff in pull request #4437: [ZEPPELIN-5786] Remove sap interpreter
Posted by GitBox <gi...@apache.org>.
HYEEWON commented on code in PR #4437:
URL: https://github.com/apache/zeppelin/pull/4437#discussion_r942303066
##########
zeppelin-web/package.json:
##########
@@ -93,7 +93,7 @@
"postcss-loader": "^3.0.0",
"protractor": "^5.4.1",
"raw-loader": "^0.5.1",
- "rimraf": "^3.0.2",
+ "rimraf": "^2.5.4",
Review Comment:
I think we should change this. Because, the version was updated in pr [#4414](https://github.com/apache/zeppelin/pull/4414).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] HYEEWON commented on a diff in pull request #4437: [ZEPPELIN-5786] Remove sap interpreter
Posted by GitBox <gi...@apache.org>.
HYEEWON commented on code in PR #4437:
URL: https://github.com/apache/zeppelin/pull/4437#discussion_r936550037
##########
zeppelin-web/package.json:
##########
@@ -93,7 +93,7 @@
"postcss-loader": "^3.0.0",
"protractor": "^5.4.1",
"raw-loader": "^0.5.1",
- "rimraf": "^3.0.2",
+ "rimraf": "^2.5.4",
Review Comment:
Hi. I have a question about this pr.
Can you tell me why you downgraded the version of `rimraf`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] kkoldduck2 commented on a diff in pull request #4437: [ZEPPELIN-5786] Remove sap interpreter
Posted by GitBox <gi...@apache.org>.
kkoldduck2 commented on code in PR #4437:
URL: https://github.com/apache/zeppelin/pull/4437#discussion_r937242091
##########
zeppelin-web/package.json:
##########
@@ -93,7 +93,7 @@
"postcss-loader": "^3.0.0",
"protractor": "^5.4.1",
"raw-loader": "^0.5.1",
- "rimraf": "^3.0.2",
+ "rimraf": "^2.5.4",
Review Comment:
Oh I'm so sorry.. it's 3.0.2 version on my local but it's changed somehow, I don't know why.. May be there was a mistake when I make pr. Should I revert this pr??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] HYEEWON commented on a diff in pull request #4437: [ZEPPELIN-5786] Remove sap interpreter
Posted by GitBox <gi...@apache.org>.
HYEEWON commented on code in PR #4437:
URL: https://github.com/apache/zeppelin/pull/4437#discussion_r942303066
##########
zeppelin-web/package.json:
##########
@@ -93,7 +93,7 @@
"postcss-loader": "^3.0.0",
"protractor": "^5.4.1",
"raw-loader": "^0.5.1",
- "rimraf": "^3.0.2",
+ "rimraf": "^2.5.4",
Review Comment:
I think we should change this. Because, the version was updated in pr [#4414](https://github.com/apache/zeppelin/pull/4414)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] kkoldduck2 commented on a diff in pull request #4437: [ZEPPELIN-5786] Remove sap interpreter
Posted by GitBox <gi...@apache.org>.
kkoldduck2 commented on code in PR #4437:
URL: https://github.com/apache/zeppelin/pull/4437#discussion_r937242091
##########
zeppelin-web/package.json:
##########
@@ -93,7 +93,7 @@
"postcss-loader": "^3.0.0",
"protractor": "^5.4.1",
"raw-loader": "^0.5.1",
- "rimraf": "^3.0.2",
+ "rimraf": "^2.5.4",
Review Comment:
Oh I'm so sorry.. it's 3.0.2 version on my local but it's changed somehow, I don't know why.. May be there was a mistake when I made PR. Should I revert this pr??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] kkoldduck2 commented on a diff in pull request #4437: [ZEPPELIN-5786] Remove sap interpreter
Posted by GitBox <gi...@apache.org>.
kkoldduck2 commented on code in PR #4437:
URL: https://github.com/apache/zeppelin/pull/4437#discussion_r937250589
##########
zeppelin-web/package.json:
##########
@@ -93,7 +93,7 @@
"postcss-loader": "^3.0.0",
"protractor": "^5.4.1",
"raw-loader": "^0.5.1",
- "rimraf": "^3.0.2",
+ "rimraf": "^2.5.4",
Review Comment:
> Oh I'm so sorry.. it's 3.0.2 version on my local but it's changed somehow, I don't know why.. May be there was a mistake when I made PR. Should I revert this pr??
I only updated rimraf version to 3.0.2 on master branch, but not on my branch 'remove_sap'. There was mistake when I made PR. If I should revert this pr, please let me know and I'll do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4437: [ZEPPELIN-5786] Remove sap interpreter
Posted by GitBox <gi...@apache.org>.
jongyoul commented on code in PR #4437:
URL: https://github.com/apache/zeppelin/pull/4437#discussion_r936807226
##########
zeppelin-web/package.json:
##########
@@ -93,7 +93,7 @@
"postcss-loader": "^3.0.0",
"protractor": "^5.4.1",
"raw-loader": "^0.5.1",
- "rimraf": "^3.0.2",
+ "rimraf": "^2.5.4",
Review Comment:
Oh? I missed this thing. I also wonder why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul merged pull request #4437: [ZEPPELIN-5786] Remove sap interpreter
Posted by GitBox <gi...@apache.org>.
jongyoul merged PR #4437:
URL: https://github.com/apache/zeppelin/pull/4437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org