[GitHub] john-bodley closed pull request #4853: [sql] Using read_sql_query instead of read_sql

[GitBox <gi...@apache.org>]

john-bodley closed pull request #4853: [sql] Using read_sql_query instead of read_sql
URL: https://github.com/apache/incubator-superset/pull/4853
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/models/core.py b/superset/models/core.py
index 05f781f7cf..576f561a2a 100644
--- a/superset/models/core.py
+++ b/superset/models/core.py
@@ -693,7 +693,7 @@ def get_quoter(self):
     def get_df(self, sql, schema):
         sql = sql.strip().strip(';')
         eng = self.get_sqla_engine(schema=schema)
-        df = pd.read_sql(sql, eng)
+        df = pd.read_sql_query(sql, eng)
 
         def needs_conversion(df_series):
             if df_series.empty:


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services