You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2019/12/29 16:39:22 UTC
[GitHub] [httpcomponents-core] garydgregory opened a new pull request #179:
Httpcore 619 event mask as a class
garydgregory opened a new pull request #179: Httpcore 619 event mask as a class
URL: https://github.com/apache/httpcomponents-core/pull/179
https://issues.apache.org/jira/browse/HTTPCORE-619
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] garydgregory commented on issue #179:
Httpcore 619 event mask as a class
Posted by GitBox <gi...@apache.org>.
garydgregory commented on issue #179: Httpcore 619 event mask as a class
URL: https://github.com/apache/httpcomponents-core/pull/179#issuecomment-569804499
>
>
> The commit log looks like a mess. Please review, but otherwise the change is fine.
>
> One could consider making the default constructor private, e.g.,
>
> ```
> private StandardCharsets() {
> throw new AssertionError("No java.nio.charset.StandardCharsets instances for you!");
> }
> ```
Please no, a final class and private default ctor yes, but just make the ctor body a comment like "// no instances."
Throwing an error here is just silly IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] garydgregory merged pull request #179:
Httpcore 619 event mask as a class
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #179: Httpcore 619 event mask as a class
URL: https://github.com/apache/httpcomponents-core/pull/179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on issue #179: Httpcore
619 event mask as a class
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #179: Httpcore 619 event mask as a class
URL: https://github.com/apache/httpcomponents-core/pull/179#issuecomment-569545934
@garydgregory Should this one be final?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on issue #179: Httpcore
619 event mask as a class
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #179: Httpcore 619 event mask as a class
URL: https://github.com/apache/httpcomponents-core/pull/179#issuecomment-569805331
@garydgregory Please go ahead and amend the commit. If you are happy with everything else, please merge the amended commit to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on issue #179: Httpcore
619 event mask as a class
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #179: Httpcore 619 event mask as a class
URL: https://github.com/apache/httpcomponents-core/pull/179#issuecomment-569806243
Looks good. Please do a fixup and merge to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on issue #179: Httpcore
619 event mask as a class
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #179: Httpcore 619 event mask as a class
URL: https://github.com/apache/httpcomponents-core/pull/179#issuecomment-569787995
The branch is now uptodate and ready to be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org