[GitHub] [pulsar] poorbarcode commented on a diff in pull request #20568: [improve] [broker] Close connection if got an IO error when sending messages to the client

["poorbarcode (via GitHub)" <gi...@apache.org>]

poorbarcode commented on code in PR #20568:
URL: https://github.com/apache/pulsar/pull/20568#discussion_r1231233890


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -1783,6 +1789,10 @@ protected void handleAck(CommandAck ack) {
                 }
                 return null;
             });
+        } else {
+            log.debug("Consumer future is not complete(not complete or error), but received command ack. so discard"

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org