You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/03/25 22:13:30 UTC
[jira] [Commented] (HBASE-5217) Reenable the thrift tests, and add
a new one for getRegionInfo
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237964#comment-13237964 ]
jiraposter@reviews.apache.org commented on HBASE-5217:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3514/
-----------------------------------------------------------
(Updated 2012-03-25 20:11:30.928544)
Review request for hbase.
Summary
-------
At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo.
This addresses bug HBASE-5217.
https://issues.apache.org/jira/browse/HBASE-5217
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java 60eb426
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java 444d6d5
Diff: https://reviews.apache.org/r/3514/diff
Testing
-------
Ran the tests with my changes in HBASE-2600 to test.
Thanks,
Alex
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira