You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2017/07/14 20:45:22 UTC

[GitHub] spark pull request #18637: [SPARK-15526][ML][FOLLOWUP][test-maven] Make JPMM...

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18637#discussion_r127544500
  
    --- Diff: pom.xml ---
    @@ -2511,8 +2523,8 @@
       <profiles>
     
         <!--
    -      This profile is enabled automatically by the sbt built. It changes the scope for the guava
    -      dependency, since we don't shade it in the artifacts generated by the sbt build.
    +      This profile is enabled automatically by the sbt build. It changes the scope for shaded
    --- End diff --
    
    I wonder if this profile is even necessary, given it does not include jetty which is also "provided" by default... but I'm too lazy to do history spelunking at the moment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org