You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/02/23 04:09:09 UTC
[GitHub] codecov-io commented on issue #3872: Add metrics to track work done
in group-by phase
codecov-io commented on issue #3872: Add metrics to track work done in group-by phase
URL: https://github.com/apache/incubator-pinot/pull/3872#issuecomment-466614428
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3872?src=pr&el=h1) Report
> Merging [#3872](https://codecov.io/gh/apache/incubator-pinot/pull/3872?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/f70935e4c2562b075c98035107a7bc00a2b5498d?src=pr&el=desc) will **decrease** coverage by `0.17%`.
> The diff coverage is `85%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/3872?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3872 +/- ##
===========================================
- Coverage 67.28% 67.1% -0.18%
Complexity 4 4
===========================================
Files 1029 1030 +1
Lines 50801 50875 +74
Branches 7098 7102 +4
===========================================
- Hits 34180 34139 -41
- Misses 14286 14417 +131
+ Partials 2335 2319 -16
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3872?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/query/aggregation/groupby/GroupKeyGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3872/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L0dyb3VwS2V5R2VuZXJhdG9yLmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/pinot/core/operator/ExecutionStatistics.java](https://codecov.io/gh/apache/incubator-pinot/pull/3872/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9FeGVjdXRpb25TdGF0aXN0aWNzLmphdmE=) | `96.42% <100%> (+0.59%)` | `0 <0> (ø)` | :arrow_down: |
| [...ion/groupby/AggregationGroupByTrimmingService.java](https://codecov.io/gh/apache/incubator-pinot/pull/3872/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L0FnZ3JlZ2F0aW9uR3JvdXBCeVRyaW1taW5nU2VydmljZS5qYXZh) | `94.53% <100%> (+0.08%)` | `0 <0> (ø)` | :arrow_down: |
| [...he/pinot/core/operator/CombineGroupByOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3872/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9Db21iaW5lR3JvdXBCeU9wZXJhdG9yLmphdmE=) | `78.72% <100%> (+1.97%)` | `0 <0> (ø)` | :arrow_down: |
| [...ry/aggregation/groupby/DefaultGroupByExecutor.java](https://codecov.io/gh/apache/incubator-pinot/pull/3872/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L0RlZmF1bHRHcm91cEJ5RXhlY3V0b3IuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ore/operator/query/AggregationGroupByOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3872/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9xdWVyeS9BZ2dyZWdhdGlvbkdyb3VwQnlPcGVyYXRvci5qYXZh) | `96% <100%> (+0.34%)` | `0 <0> (ø)` | :arrow_down: |
| [...core/operator/blocks/IntermediateResultsBlock.java](https://codecov.io/gh/apache/incubator-pinot/pull/3872/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvSW50ZXJtZWRpYXRlUmVzdWx0c0Jsb2NrLmphdmE=) | `76.15% <100%> (+1.98%)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/pinot/common/metrics/ServerMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3872/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9TZXJ2ZXJNZXRlci5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/query/aggregation/groupby/GroupByStatistics.java](https://codecov.io/gh/apache/incubator-pinot/pull/3872/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L0dyb3VwQnlTdGF0aXN0aWNzLmphdmE=) | `44.44% <44.44%> (ø)` | `0 <0> (?)` | |
| [...upby/NoDictionaryMultiColumnGroupKeyGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3872/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L05vRGljdGlvbmFyeU11bHRpQ29sdW1uR3JvdXBLZXlHZW5lcmF0b3IuamF2YQ==) | `91.91% <66.66%> (-0.79%)` | `0 <0> (ø)` | |
| ... and [34 more](https://codecov.io/gh/apache/incubator-pinot/pull/3872/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3872?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3872?src=pr&el=footer). Last update [f70935e...566f452](https://codecov.io/gh/apache/incubator-pinot/pull/3872?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org