You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemml.apache.org by GitBox <gi...@apache.org> on 2020/06/01 08:54:07 UTC
[GitHub] [systemml] Baunsgaard commented on a change in pull request #909: [SYSTEMDS-???] [WIP] Distinct values estimation function
Baunsgaard commented on a change in pull request #909:
URL: https://github.com/apache/systemml/pull/909#discussion_r433117510
##########
File path: src/main/java/org/apache/sysds/hops/AggUnaryOp.java
##########
@@ -102,7 +102,10 @@ else if ((_op == AggOp.SUM && (_direction == Direction.RowCol || _direction =
|| (_op == AggOp.MIN && (_direction == Direction.RowCol || _direction == Direction.Row || _direction == Direction.Col))
|| (_op == AggOp.MEAN && (_direction == Direction.RowCol || _direction == Direction.Row || _direction == Direction.Col))
|| (_op == AggOp.VAR && (_direction == Direction.RowCol || _direction == Direction.Row || _direction == Direction.Col))
- || (_op == AggOp.PROD && (_direction == Direction.RowCol))){
+ || (_op == AggOp.PROD && (_direction == Direction.RowCol))
+ || (_op == AggOp.COUNT_DISTINCT && (_direction == Direction.RowCol))
+ || (_op == AggOp.COUNT_DISTINCT_ESTIMATE_KMV && (_direction == Direction.RowCol))
Review comment:
Ha :), maybe I should have looked at the method name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org