Re: [PR] feat: add initial support for camel-k [camel-spring-boot]

["davsclaus (via GitHub)" <gi...@apache.org>]

davsclaus commented on code in PR #1097:
URL: https://github.com/apache/camel-spring-boot/pull/1097#discussion_r1508638758


##########
core/camel-spring-boot/src/main/java/org/apache/camel/spring/boot/CamelAutoConfiguration.java:
##########
@@ -189,6 +197,12 @@ public static CamelContext doConfigureCamelContext(ApplicationContext applicatio
         // and call after all properties are set
         DefaultConfigurationConfigurer.afterPropertiesSet(camelContext);
 
+        // apply custom configurations if any
+        // TODO: this must be evaluated as I don't know if it makes sense here.
+        contextCustomizers.stream()
+                .sorted(Comparator.comparing(CamelContextCustomizer::getOrder))
+                .forEach(c -> c.configure(camelContext));

Review Comment:
   Yeah its something you added, and its not much in use. In camel-core we use it for yaml-dsl but then its internally handled there, and not something that requires camel to trigger on startup.
   
   I am look at that mapstruct thing now ... curious why its there



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org