You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/01 19:07:31 UTC

[GitHub] [beam] lukecwik commented on a change in pull request #11867: [BEAM-10158] Use a shared unbounded thread pool within Beam Python.

lukecwik commented on a change in pull request #11867:
URL: https://github.com/apache/beam/pull/11867#discussion_r433431576



##########
File path: sdks/python/apache_beam/utils/thread_pool_executor.py
##########
@@ -134,3 +134,12 @@ def shutdown(self, wait=True):
       if wait:
         for worker in self._workers:
           worker.join()
+
+
+class _SharedUnboundedThreadPoolExecutor(UnboundedThreadPoolExecutor):

Review comment:
       People can still use UnboundedThreadPoolExecutor and there could be a usecase around having threads from the pool having meaningful names to simplify debugging so I'm going to leave it as is.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org