[GitHub] yanghua commented on issue #7248: [hotfix][tableApi] Fix the description information of intersect in tableApi docs

[GitBox <gi...@apache.org>]

yanghua commented on issue #7248: [hotfix][tableApi] Fix the description information of intersect in tableApi docs
URL: https://github.com/apache/flink/pull/7248#issuecomment-446808073
 
 
   @fhueske you are right. 
   But there may be some points that can be misleading for some users:
   
   * Sometimes fields of the same name are more easily visually identified as having the same type;
   * Multiple test methods in `SetOperatorsITCase` explicitly specify the same fields (a, b, c) for the left and right Tables, because the document is just an incomplete example, sometimes after the user views the document, they will try to go to the project. Search for source code and see real cases;
   * Other operators of multi-table operations in the same document such as `union`, `minus` also use the same field name
   
   This is why I said LGTM. But in fact, for those who understand the use of this operator, it does not matter whether it is modified or not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services