You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/07 13:35:10 UTC

[GitHub] [incubator-superset] aspedrosa opened a new pull request #8527: Avoid fetch fav dashboard stat not logged in

aspedrosa opened a new pull request #8527: Avoid fetch fav dashboard stat not logged in
URL: https://github.com/apache/incubator-superset/pull/8527
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   As explained in #8501, if you allow non logged in users to see dashboards, the favorite status of that dashboard will still be fetched, causing an error toast to appear.
   To fix it I check if the userId present on the dashboardInfo prop of the Header component is valid, and only if it is, the span related to the fav-star is rendered.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   ![fav-start-showing](https://user-images.githubusercontent.com/23409890/68392333-7daa7500-0161-11ea-858e-4aebe2f6b71b.png)
   ![fav-start-not-showing](https://user-images.githubusercontent.com/23409890/68392337-7edba200-0161-11ea-934d-602e95889cc6.png)
   
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   There's already a test that verifies if the fav-start is displayed and works correctly
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: #8501
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org