You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@twill.apache.org by GitBox <gi...@apache.org> on 2020/01/15 19:16:17 UTC
[GitHub] [twill] CuriousVini opened a new pull request #84: (TWILL-265)
Upgrading kafka version and removing lz4 dependency
CuriousVini opened a new pull request #84: (TWILL-265) Upgrading kafka version and removing lz4 dependency
URL: https://github.com/apache/twill/pull/84
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [twill] chtyim commented on a change in pull request #84:
(TWILL-265) Upgrading kafka version and removing lz4 dependency
Posted by GitBox <gi...@apache.org>.
chtyim commented on a change in pull request #84: (TWILL-265) Upgrading kafka version and removing lz4 dependency
URL: https://github.com/apache/twill/pull/84#discussion_r367742700
##########
File path: twill-core/src/test/java/org/apache/twill/kafka/client/KafkaTest.java
##########
@@ -135,6 +135,9 @@ public void finished() {
server = new EmbeddedKafkaServer(kafkaServerConfig);
server.startAndWait();
+ // Wait a little while to make sure changes is reflected in broker service
+ TimeUnit.SECONDS.sleep(3);
Review comment:
It is probably worth to expose the `BrokerService` from the `KafkaClient` and you can have a more efficient wait by use the `BrokerService.addChangeListener` method or simply poll from the `BrokerService.getBrokerList()` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [twill] asfgit closed pull request #84: (TWILL-265) Upgrading kafka
version and removing lz4 dependency
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #84: (TWILL-265) Upgrading kafka version and removing lz4 dependency
URL: https://github.com/apache/twill/pull/84
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [twill] CuriousVini commented on a change in pull request #84:
(TWILL-265) Upgrading kafka version and removing lz4 dependency
Posted by GitBox <gi...@apache.org>.
CuriousVini commented on a change in pull request #84: (TWILL-265) Upgrading kafka version and removing lz4 dependency
URL: https://github.com/apache/twill/pull/84#discussion_r368149843
##########
File path: twill-core/src/test/java/org/apache/twill/kafka/client/KafkaTest.java
##########
@@ -135,6 +135,9 @@ public void finished() {
server = new EmbeddedKafkaServer(kafkaServerConfig);
server.startAndWait();
+ // Wait a little while to make sure changes is reflected in broker service
+ TimeUnit.SECONDS.sleep(3);
Review comment:
I kept it same as `testBrokerChange()`. But I agree the suggested approach would be a little bit more efficient implementation.
I will open another pr with that enhancement to both the tests to keep the changes in this pr related to kafka version upgrade.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [twill] CuriousVini commented on a change in pull request #84:
(TWILL-265) Upgrading kafka version and removing lz4 dependency
Posted by GitBox <gi...@apache.org>.
CuriousVini commented on a change in pull request #84: (TWILL-265) Upgrading kafka version and removing lz4 dependency
URL: https://github.com/apache/twill/pull/84#discussion_r368149843
##########
File path: twill-core/src/test/java/org/apache/twill/kafka/client/KafkaTest.java
##########
@@ -135,6 +135,9 @@ public void finished() {
server = new EmbeddedKafkaServer(kafkaServerConfig);
server.startAndWait();
+ // Wait a little while to make sure changes is reflected in broker service
+ TimeUnit.SECONDS.sleep(3);
Review comment:
I kept it same as `testBrokerChange()`. But I agree the suggested approach would be a little bit more efficient implementation.
I will open another pr with that small enhancement to keep the changes in this pr related to kafka version upgrade.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services