[GitHub] [arrow-datafusion] korowa commented on a diff in pull request #2649: MINOR: Implement serde for join filter

[GitBox <gi...@apache.org>]

korowa commented on code in PR #2649:
URL: https://github.com/apache/arrow-datafusion/pull/2649#discussion_r884440270


##########
datafusion/proto/src/logical_plan.rs:
##########
@@ -605,6 +605,11 @@ impl AsLogicalPlan for LogicalPlanNode {
                         join.join_constraint
                     ))
                 })?;
+                let filter: Option<Expr> = join
+                    .filter
+                    .as_ref()
+                    .map(|expr| parse_expr(expr, ctx))
+                    .map_or(Ok(None), |v| v.map(Some))?;

Review Comment:
   Transpose seems to be appropriate -- I used this map_or call in ballista for conversion from Option<Result> to Result<Option>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org