You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by apetresc <gi...@git.apache.org> on 2014/06/24 00:01:01 UTC
[GitHub] incubator-storm pull request: Fix typo in storm_env.ini
GitHub user apetresc opened a pull request:
https://github.com/apache/incubator-storm/pull/156
Fix typo in storm_env.ini
pytyon -> python, and tense agreement.
Least-significant PR in the world, is it even worth opening a JIRA issue for it?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apetresc/incubator-storm patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/156.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #156
----
commit d79b423691100c05c0cb2906da458c85d3feaa7b
Author: Adrian Petrescu <ap...@gmail.com>
Date: 2014-06-23T22:00:50Z
Fix typo in storm_env.ini
pytyon -> python, and tense agreement.
Least-significant PR in the world, is it even worth opening a JIRA issue for it?
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Fix typo in storm_env.ini
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/156#issuecomment-47105617
The code change looks fine to me I am +1, although technically we probably need a JIRA for this too. @ptgoetz are we going to enforce that tracking? If not we can list the pull request in the CHANGELOG, but It would mean that someone would need to look at 2 or more locations to see what changed in a release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Fix typo in storm_env.ini
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/incubator-storm/pull/156#issuecomment-46922529
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Fix typo in storm_env.ini
Posted by apetresc <gi...@git.apache.org>.
Github user apetresc commented on the pull request:
https://github.com/apache/incubator-storm/pull/156#issuecomment-47111781
Okay, no problem, I'll file a JIRA! I certainly don't wanna make anyone change a process for this, just figured it might not even need a CHANGELOG entry since it's only a comment.
Will file JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-372. Typo in storm_env.ini
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/156#issuecomment-47133044
OK I am fully a +1 now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-372. Typo in storm_env.ini
Posted by apetresc <gi...@git.apache.org>.
Github user apetresc commented on the pull request:
https://github.com/apache/incubator-storm/pull/156#issuecomment-47112986
[JIRA link](https://issues.apache.org/jira/browse/STORM-372)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-372. Typo in storm_env.ini
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-storm/pull/156
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---