You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Lee-W (via GitHub)" <gi...@apache.org> on 2024/11/27 09:40:08 UTC
[I] Asset related REST API endpoints rework [airflow]
Lee-W opened a new issue, #44412:
URL: https://github.com/apache/airflow/issues/44412
### Description
We used to have `/api/v1/datasets/{uri}` in airflow 2.x and changed into `/api/v1/assets/{uri}` for airflow 3.0, but this could raise the issue as assets now have a new attribute `name.`
After discussion with @uranusjr , it should be changed into `/api/v1/assets/{name}` instead. As `Asset("s3://...")` generates an asset with name and URI set to `s3://...`, it should still make sense.
But there would be two more things to consider.
1. Whether we want to filter assets by URI
2. Whehter we want to list the assets that are not active
### Use case/motivation
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Asset related REST API endpoints rework [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on issue #44412:
URL: https://github.com/apache/airflow/issues/44412#issuecomment-2503394437
@jedcunningham @ephraimbuddy would like to know whether we're still returning a DAG that is deleted after DAG versioning. If not, we'll probably also not return non-active assets in the API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Asset related REST API endpoints rework [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on issue #44412:
URL: https://github.com/apache/airflow/issues/44412#issuecomment-2562095754
We already merged #44801 to solve the URI part. I’m not sure what we should do for the activeness part since we don’t have a real use case yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Asset related REST API endpoints rework [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W closed issue #44412: Asset related REST API endpoints rework
URL: https://github.com/apache/airflow/issues/44412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Asset related REST API endpoints rework [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on issue #44412:
URL: https://github.com/apache/airflow/issues/44412#issuecomment-2562044477
@uranusjr If my memory serves correct, we're waiting for the UI folks for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Asset related REST API endpoints rework [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on issue #44412:
URL: https://github.com/apache/airflow/issues/44412#issuecomment-2503537216
> > I think you mean a DAG whose file is deleted. If so, all we do is mark the dag as inactive, just as before. It didn't change. The only change is that the serdag for such dag won't be deleted, but previously, it would have been deleted.
>
> will we still be able to get it through REST API?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Asset related REST API endpoints rework [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on issue #44412:
URL: https://github.com/apache/airflow/issues/44412#issuecomment-2503432438
> so
will we still be able to get it through REST API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Asset related REST API endpoints rework [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on issue #44412:
URL: https://github.com/apache/airflow/issues/44412#issuecomment-2562136116
> We already merged #44801 to solve the URI part. I’m not sure what we should do for the activeness part since we don’t have a real use case yet.
ah yes, forget about that one. then I'll close this one till we have a concrete idea on what needs to be done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Asset related REST API endpoints rework [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on issue #44412:
URL: https://github.com/apache/airflow/issues/44412#issuecomment-2503426967
> @jedcunningham @ephraimbuddy would like to know whether we're still returning a DAG that is deleted after DAG versioning. If not, we'll probably also not return non-active assets in the API
I think you mean a DAG whose file is deleted. If so, all we do is mark the dag as inactive, just as before. It didn't change. The only change is that the serdag for such dag won't be deleted, but previously, it would have been deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org