You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zuxqoj <gi...@git.apache.org> on 2015/04/27 13:25:16 UTC

[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

GitHub user zuxqoj opened a pull request:

    https://github.com/apache/spark/pull/5719

    [SPARK-6653][yarn] New config to specify port for sparkYarnAM actor system

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zuxqoj/spark master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/5719.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5719
    
----
commit 803e93e079dd4fe247265b25f93db11537bfc699
Author: shekhar.bansal <sh...@guavus.com>
Date:   2015-04-27T11:23:46Z

    [SPARK-6653][yarn] New configuration property to specify port for sparkYarnAM actor system

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/5719#issuecomment-96624945
  
    @zsxwing @vanzin what do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by tgravescs <gi...@git.apache.org>.
Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5719#discussion_r29169815
  
    --- Diff: docs/running-on-yarn.md ---
    @@ -134,6 +134,13 @@ Most of the configs are the same for Spark on YARN as for other deployment modes
       </td>
     </tr>
     <tr>
    +  <td><code>spark.yarn.am.port</code></td>
    +  <td>(random)</td>
    +  <td>
    +    Port for the YARN Application Master to listen on.
    --- End diff --
    
    Unless I'm missing something this is only used in yarn client mode.  This the communication channel (rpc) between AM on cluster and driver on the client side.  It looks like the rest of spark uses things just like spark.executor.port, spark.driver.port, etc.. So this kind of follows that convention.  Personally I would like it more descriptive but since that is kind of convention I'm ok with it.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by zuxqoj <gi...@git.apache.org>.
Github user zuxqoj commented on the pull request:

    https://github.com/apache/spark/pull/5719#issuecomment-96621621
  
    added "spark.yarn.am.port" in running-on-yarn.md


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by tgravescs <gi...@git.apache.org>.
Github user tgravescs commented on the pull request:

    https://github.com/apache/spark/pull/5719#issuecomment-96770549
  
    ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by zuxqoj <gi...@git.apache.org>.
Github user zuxqoj commented on the pull request:

    https://github.com/apache/spark/pull/5719#issuecomment-96749521
  
    @vanzin user is expected to specify different port number for different  application.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/5719#issuecomment-97328462
  
      [Test build #31258 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31258/consoleFull) for   PR 5719 at commit [`9de5330`](https://github.com/apache/spark/commit/9de53309551960fde7395074bff12279e00d0fb5).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/5719#issuecomment-97354102
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31258/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/5719#issuecomment-97328335
  
     Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by tgravescs <gi...@git.apache.org>.
Github user tgravescs commented on the pull request:

    https://github.com/apache/spark/pull/5719#issuecomment-96752349
  
    There is also a separate jira to add support for port ranges.  SPARK-4449


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/5719#issuecomment-96766468
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by zuxqoj <gi...@git.apache.org>.
Github user zuxqoj commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5719#discussion_r29325916
  
    --- Diff: docs/running-on-yarn.md ---
    @@ -134,6 +134,13 @@ Most of the configs are the same for Spark on YARN as for other deployment modes
       </td>
     </tr>
     <tr>
    +  <td><code>spark.yarn.am.port</code></td>
    +  <td>(random)</td>
    +  <td>
    +    Port for the YARN Application Master to listen on.
    --- End diff --
    
    I am not 100% sure but I think it does communicate with driver also, in runAMEndpoint method it is creating RpcEndpoint to communicate with driver. Can someone please confirm, I will update description accordingly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/5719#issuecomment-96622735
  
      [Test build #718 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/718/consoleFull) for   PR 5719 at commit [`456a592`](https://github.com/apache/spark/commit/456a59249a49d35d89cc7db4e53b1d0b39fa174d).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/5719#issuecomment-96616814
  
    Does this need to be documented too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by zuxqoj <gi...@git.apache.org>.
Github user zuxqoj commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5719#discussion_r29168897
  
    --- Diff: docs/running-on-yarn.md ---
    @@ -134,6 +134,13 @@ Most of the configs are the same for Spark on YARN as for other deployment modes
       </td>
     </tr>
     <tr>
    +  <td><code>spark.yarn.am.port</code></td>
    +  <td>(random)</td>
    +  <td>
    +    Port for the YARN Application Master to listen on.
    --- End diff --
    
    @sryza what do you suggest.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/5719#issuecomment-97354084
  
      [Test build #31258 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31258/consoleFull) for   PR 5719 at commit [`9de5330`](https://github.com/apache/spark/commit/9de53309551960fde7395074bff12279e00d0fb5).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.
     * This patch does not change any dependencies.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by zuxqoj <gi...@git.apache.org>.
Github user zuxqoj commented on the pull request:

    https://github.com/apache/spark/pull/5719#issuecomment-96618549
  
    I think we should document it.
    I will update running-on-yarn.md also


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the pull request:

    https://github.com/apache/spark/pull/5719#issuecomment-96750900
  
    @vanzin, Rpc.create will call `Utils.startServiceOnPort` to find another port for port conflicts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/5719#issuecomment-96656843
  
      [Test build #718 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/718/consoleFull) for   PR 5719 at commit [`456a592`](https://github.com/apache/spark/commit/456a59249a49d35d89cc7db4e53b1d0b39fa174d).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.
     * This patch does not change any dependencies.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by tgravescs <gi...@git.apache.org>.
Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5719#discussion_r29148444
  
    --- Diff: docs/running-on-yarn.md ---
    @@ -134,6 +134,13 @@ Most of the configs are the same for Spark on YARN as for other deployment modes
       </td>
     </tr>
     <tr>
    +  <td><code>spark.yarn.am.port</code></td>
    +  <td>(random)</td>
    +  <td>
    +    Port for the YARN Application Master to listen on.
    --- End diff --
    
    I think we should be more specific in the description of this.  an application master could have many ports open, what is this one for.  I think either put in name or atleast put in description.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by tgravescs <gi...@git.apache.org>.
Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5719#discussion_r29337481
  
    --- Diff: docs/running-on-yarn.md ---
    @@ -134,6 +134,13 @@ Most of the configs are the same for Spark on YARN as for other deployment modes
       </td>
     </tr>
     <tr>
    +  <td><code>spark.yarn.am.port</code></td>
    +  <td>(random)</td>
    +  <td>
    +    Port for the YARN Application Master to listen on. This is used for communicating with the executors.
    --- End diff --
    
    this is not the channel used to communicate with executors.
    This channel is used in yarn client mode to communicate between the spark driver running on a gateway and the application master (which is doing container requests) running on yarn.
    
    It also looks like I was wrong  my previous comment. It actually is also used in yarn cluster mode.  Its used for the dynamic executor feature, where it is handling the kill from the scheduler backend.   
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/5719#issuecomment-97328345
  
    Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/5719#issuecomment-96743993
  
    So, isn't a single port here kind of limiting? If you're unlucky and two AMs start on the same node, one of them will fail. Wouldn't it be better to have a port range here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by sryza <gi...@git.apache.org>.
Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5719#discussion_r29167101
  
    --- Diff: docs/running-on-yarn.md ---
    @@ -134,6 +134,13 @@ Most of the configs are the same for Spark on YARN as for other deployment modes
       </td>
     </tr>
     <tr>
    +  <td><code>spark.yarn.am.port</code></td>
    +  <td>(random)</td>
    +  <td>
    +    Port for the YARN Application Master to listen on.
    --- End diff --
    
    Also kind of confusing is that in other places we use the `spark.yarn.am.*` namespace to refer only to the yarn-client application master.  If this applies to both yarn-client and yarn-cluster, the naming is kind of inconsistent.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/5719#issuecomment-96749829
  
    That is not very user-friendly at all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/5719#issuecomment-96751714
  
    > Rpc.create will call Utils.startServiceOnPort to find another port for port conflicts.
     
    I see. In that case the documentation added in this change is wrong, since the actual port will be anything between `x` and `x + spark.port.maxRetries`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/5719#issuecomment-97354100
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-6653][yarn] New config to specify port ...

Posted by WangTaoTheTonic <gi...@git.apache.org>.
Github user WangTaoTheTonic commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5719#discussion_r29315711
  
    --- Diff: docs/running-on-yarn.md ---
    @@ -134,6 +134,13 @@ Most of the configs are the same for Spark on YARN as for other deployment modes
       </td>
     </tr>
     <tr>
    +  <td><code>spark.yarn.am.port</code></td>
    +  <td>(random)</td>
    +  <td>
    +    Port for the YARN Application Master to listen on. This is used for communicating with the executors.
    --- End diff --
    
    Is this channel to communicate with driver either?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org