You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2017/09/13 18:25:00 UTC

Review Request 62289: Package Installation is failing If Patch-VDF contain service that is not installed in the cluster

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62289/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Bugs: AMBARI-21950
    https://issues.apache.org/jira/browse/AMBARI-21950


Repository: ambari


Description
-------

The check for services in the VDF is being done AFTER setting all the hosts to INSTALLING.

Added assertions to verify that is or is not happening.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java c2084b6954 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 06e8dfa8ba 


Diff: https://reviews.apache.org/r/62289/diff/1/


Testing
-------

Manual.  Automated pending.


Thanks,

Nate Cole


Re: Review Request 62289: Package Installation is failing If Patch-VDF contain service that is not installed in the cluster

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62289/#review185343
-----------------------------------------------------------


Ship it!




Ship It!

- Jonathan Hurley


On Sept. 13, 2017, 2:25 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62289/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2017, 2:25 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21950
>     https://issues.apache.org/jira/browse/AMBARI-21950
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The check for services in the VDF is being done AFTER setting all the hosts to INSTALLING.
> 
> Added assertions to verify that is or is not happening.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java c2084b6954 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 06e8dfa8ba 
> 
> 
> Diff: https://reviews.apache.org/r/62289/diff/1/
> 
> 
> Testing
> -------
> 
> Manual.  Automated:
> 
> [WARNING] Tests run: 4861, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:08.786s
> [INFO] Finished at: Wed Sep 13 15:20:51 EDT 2017
> [INFO] Final Memory: 68M/1910M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 62289: Package Installation is failing If Patch-VDF contain service that is not installed in the cluster

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

> On Sept. 14, 2017, 2 p.m., Dmitro Lisnichenko wrote:
> > Ship It!

my bad


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62289/#review185391
-----------------------------------------------------------


On Sept. 13, 2017, 9:25 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62289/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2017, 9:25 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21950
>     https://issues.apache.org/jira/browse/AMBARI-21950
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The check for services in the VDF is being done AFTER setting all the hosts to INSTALLING.
> 
> Added assertions to verify that is or is not happening.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java c2084b6954 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 06e8dfa8ba 
> 
> 
> Diff: https://reviews.apache.org/r/62289/diff/1/
> 
> 
> Testing
> -------
> 
> Manual.  Automated:
> 
> [WARNING] Tests run: 4861, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:08.786s
> [INFO] Finished at: Wed Sep 13 15:20:51 EDT 2017
> [INFO] Final Memory: 68M/1910M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 62289: Package Installation is failing If Patch-VDF contain service that is not installed in the cluster

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62289/#review185391
-----------------------------------------------------------


Ship it!




Ship It!

- Dmitro Lisnichenko


On Sept. 13, 2017, 9:25 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62289/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2017, 9:25 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21950
>     https://issues.apache.org/jira/browse/AMBARI-21950
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The check for services in the VDF is being done AFTER setting all the hosts to INSTALLING.
> 
> Added assertions to verify that is or is not happening.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java c2084b6954 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 06e8dfa8ba 
> 
> 
> Diff: https://reviews.apache.org/r/62289/diff/1/
> 
> 
> Testing
> -------
> 
> Manual.  Automated:
> 
> [WARNING] Tests run: 4861, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:08.786s
> [INFO] Finished at: Wed Sep 13 15:20:51 EDT 2017
> [INFO] Final Memory: 68M/1910M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>