You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2016/08/11 15:37:07 UTC

[GitHub] nifi pull request #837: Controller Services - Addressing issues with transit...

GitHub user mcgilman opened a pull request:

    https://github.com/apache/nifi/pull/837

    Controller Services - Addressing issues with transitive referencing components

    NIFI-2542: - Ensuring transitive referencing components are able to be returned. 
    
    NIFI-2543: - Ensuring we have permissions before attempting to reload a controller service.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mcgilman/nifi NIFI-2542

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/837.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #837
    
----
commit 17fbf55972fa81e7f5cccfd01fe833dbdc6326f7
Author: Matt Gilman <ma...@gmail.com>
Date:   2016-08-11T14:52:04Z

    NIFI-2542: - Ensuring transitive referencing components are able to be returned. NIFI-2543: - Ensuring we have permissions before attempting to reload a controller service.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #837: Controller Services - Addressing issues with transitive ref...

Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:

    https://github.com/apache/nifi/pull/837
  
    Reviewing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #837: Controller Services - Addressing issues with transit...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/837


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #837: Controller Services - Addressing issues with transitive ref...

Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:

    https://github.com/apache/nifi/pull/837
  
    +1
    
    Visually verified code and did a contrib check build. In a standalone cluster tested many different levels of transitive dependencies using DetectDuplicate -> DistributeMapCacheClientService -> SSLContextService and enabling and disabling referenced components, and all behaved as expected. Looks good @mcgilman, I will merge it in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---