You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Misty Stanley-Jones (Code Review)" <ge...@cloudera.org> on 2016/07/13 21:50:07 UTC
[kudu-CR] KUDU-1517 Implement doc feedback from Sue M
Misty Stanley-Jones has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3638
Change subject: KUDU-1517 Implement doc feedback from Sue M
......................................................................
KUDU-1517 Implement doc feedback from Sue M
Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
---
M docs/index.adoc
M docs/release_notes.adoc
2 files changed, 54 insertions(+), 61 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/3638/1
--
To view, visit http://gerrit.cloudera.org:8080/3638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones <mi...@apache.org>
[kudu-CR] KUDU-1517 Implement doc feedback from Sue M
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: KUDU-1517 Implement doc feedback from Sue M
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/2921/
--
To view, visit http://gerrit.cloudera.org:8080/3638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1517 Implement doc feedback from Sue M
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: KUDU-1517 Implement doc feedback from Sue M
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3638/1/docs/index.adoc
File docs/index.adoc:
PS1, Line 79: FROM
> Great that we support this feature. Thanks for the syntax details Matt.
Sure.
Here's a fancy example of an UPDATE:
[localhost:21000] > explain update default.managed_kudu set name = t1.string_col from managed_kudu inner join ( select id, string_col from functional.alltypestiny ) t1 where x = t1.id;
Query: explain update default.managed_kudu set name = t1.string_col from managed_kudu inner join ( select id, string_col from functional.alltypestiny ) t1 where x = t1.id
Query submitted at: 2016-08-15 16:20:42 (Coordinator: http://0.0.0.0:25000)
Query progress can be monitored at: http://0.0.0.0:25000/query_plan?query_id=56437d577087cd04:f6b43be2772bb7bf
+------------------------------------------------------------------------------------+
| Explain String |
+------------------------------------------------------------------------------------+
| Estimated Per-Host Requirements: Memory=2.03GB VCores=2 |
| WARNING: The following tables are missing relevant table and/or column statistics. |
| default.managed_kudu |
| |
| UPDATE KUDU [default.managed_kudu] |
| | check keys exist: false |
| | |
| 02:HASH JOIN [INNER JOIN, BROADCAST] |
| | hash predicates: id = x |
| | runtime filters: RF000 <- x |
| | |
| |--03:EXCHANGE [BROADCAST] |
| | | |
| | 00:SCAN KUDU [default.managed_kudu] |
| | |
| 01:SCAN HDFS [functional.alltypestiny] |
| partitions=4/4 files=4 size=460B |
| runtime filters: RF000 -> id |
+------------------------------------------------------------------------------------+
--
To view, visit http://gerrit.cloudera.org:8080/3638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1517 Implement doc feedback from Sue M
Posted by "Misty Stanley-Jones (Code Review)" <ge...@cloudera.org>.
Misty Stanley-Jones has submitted this change and it was merged.
Change subject: KUDU-1517 Implement doc feedback from Sue M
......................................................................
KUDU-1517 Implement doc feedback from Sue M
Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Reviewed-on: http://gerrit.cloudera.org:8080/3638
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M docs/index.adoc
M docs/release_notes.adoc
2 files changed, 55 insertions(+), 61 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Anonymous Coward #149
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
[kudu-CR] KUDU-1517 Implement doc feedback from Sue M
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Anonymous Coward #149 has posted comments on this change.
Change subject: KUDU-1517 Implement doc feedback from Sue M
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3638/1/docs/index.adoc
File docs/index.adoc:
PS1, Line 85:
, (Oxford comma :-)
--
To view, visit http://gerrit.cloudera.org:8080/3638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Anonymous Coward #149
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1517 Implement doc feedback from Sue M
Posted by "Misty Stanley-Jones (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3638
to look at the new patch set (#3).
Change subject: KUDU-1517 Implement doc feedback from Sue M
......................................................................
KUDU-1517 Implement doc feedback from Sue M
Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
---
M docs/index.adoc
M docs/release_notes.adoc
2 files changed, 55 insertions(+), 61 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/3638/3
--
To view, visit http://gerrit.cloudera.org:8080/3638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Anonymous Coward #149
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
[kudu-CR] KUDU-1517 Implement doc feedback from Sue M
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: KUDU-1517 Implement doc feedback from Sue M
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3638/1/docs/index.adoc
File docs/index.adoc:
PS1, Line 79: FROM
> Sure.
Based on what Matt wrote, let's just say "you can specify complex joins with a `FROM` clause." (and leave off the subquery part). We should also document the UPDATE / DELETE syntax for Impala, which I have not found documented anywhere. Maybe John Russell knows if it's documented already?
--
To view, visit http://gerrit.cloudera.org:8080/3638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Anonymous Coward #149
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1517 Implement doc feedback from Sue M
Posted by "Misty Stanley-Jones (Code Review)" <ge...@cloudera.org>.
Misty Stanley-Jones has posted comments on this change.
Change subject: KUDU-1517 Implement doc feedback from Sue M
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3638/1/docs/index.adoc
File docs/index.adoc:
PS1, Line 79: FROM
> For DELETE Impala supports the following syntax:
Thanks. I have linked John to this comment as I believe these nuances belong in Impala docs. I'll add "Not all types of joins have been tested" and be happy with the Kudu docs, as this is just part of a feature listing.
--
To view, visit http://gerrit.cloudera.org:8080/3638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1517 Implement doc feedback from Sue M
Posted by "Misty Stanley-Jones (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3638
to look at the new patch set (#2).
Change subject: KUDU-1517 Implement doc feedback from Sue M
......................................................................
KUDU-1517 Implement doc feedback from Sue M
Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
---
M docs/index.adoc
M docs/release_notes.adoc
2 files changed, 55 insertions(+), 61 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/3638/2
--
To view, visit http://gerrit.cloudera.org:8080/3638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
[kudu-CR] KUDU-1517 Implement doc feedback from Sue M
Posted by "Misty Stanley-Jones (Code Review)" <ge...@cloudera.org>.
Misty Stanley-Jones has posted comments on this change.
Change subject: KUDU-1517 Implement doc feedback from Sue M
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/3638/1/docs/index.adoc
File docs/index.adoc:
PS1, Line 85:
> , (Oxford comma :-)
Done
http://gerrit.cloudera.org:8080/#/c/3638/1/docs/release_notes.adoc
File docs/release_notes.adoc:
Line 31: == Introduction
> nit: I think this should be a 3rd-level heading
Done
--
To view, visit http://gerrit.cloudera.org:8080/3638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Anonymous Coward #149
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1517 Implement doc feedback from Sue M
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: KUDU-1517 Implement doc feedback from Sue M
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3638/1/docs/index.adoc
File docs/index.adoc:
PS1, Line 79: FROM
> I would say: you can specify complex joins with a FROM clause in a subquery
For DELETE Impala supports the following syntax:
DELETE [FROM] target_table_name where_clause
and the where_clause is the same where_clause you'd have for a select stmt. You can have subqueries in there if you want, e.g.
delete from kudutbl where id in ( select other_id from another_tbl );
you could have put a join in there if you want.
For UPDATE you don't have the optional FROM keyword before target_table_name, but there is a FROM keyword before the source table(s).
UPDATE target_table
SET col_name = expr [, ... // more cols to set ]
FROM source_table [, ... // more source tables ]
WHERE expr [, ... // more predicates ]
In there you should be able to put a subquery in the source tables.
I suspect the confusion comes from the difference in where the FROM goes. Perhaps we should separate them out.
--
To view, visit http://gerrit.cloudera.org:8080/3638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1517 Implement doc feedback from Sue M
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: KUDU-1517 Implement doc feedback from Sue M
......................................................................
Patch Set 1:
(11 comments)
http://gerrit.cloudera.org:8080/#/c/3638/1/docs/index.adoc
File docs/index.adoc:
PS1, Line 73: mechanism
s/mechanisms/syntax/
PS1, Line 74: any other table with HDFS or HBase persistenc
as any other Impala table, like those using HDFS or HBase for persistence.
PS1, Line 78: solutions
s/solutions/standards/
PS1, Line 78: to
s/to/with/
PS1, Line 79: FROM
I would say: you can specify complex joins with a FROM clause in a subquery
However, I am not sure if it's true that this works for updates with Impala and Kudu. Are you sure? I suppose this means you can do something like what is shown in this SO article: http://stackoverflow.com/questions/1293330/how-can-i-do-an-update-statement-with-join-in-sql
PS1, Line 89: within
s/within/used by/
PS1, Line 89: to
s/to/across/
Line 108: Data Compression:: Because a given column contains only one type of data, pattern-based compression can
nit: Would be nice to keep this line under 100 chars long
PS1, Line 185: when using
s/when using/in/
PS1, Line 236: and
nit: and and
http://gerrit.cloudera.org:8080/#/c/3638/1/docs/release_notes.adoc
File docs/release_notes.adoc:
Line 31: == Introduction
nit: I think this should be a 3rd-level heading
--
To view, visit http://gerrit.cloudera.org:8080/3638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1517 Implement doc feedback from Sue M
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: KUDU-1517 Implement doc feedback from Sue M
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3638/1/docs/index.adoc
File docs/index.adoc:
PS1, Line 79: FROM
> For DELETE Impala supports the following syntax:
Great that we support this feature. Thanks for the syntax details Matt.
--
To view, visit http://gerrit.cloudera.org:8080/3638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1517 Implement doc feedback from Sue M
Posted by "Misty Stanley-Jones (Code Review)" <ge...@cloudera.org>.
Misty Stanley-Jones has posted comments on this change.
Change subject: KUDU-1517 Implement doc feedback from Sue M
......................................................................
Patch Set 4:
Submitted. The follow-up syntax for Impala should be documented by John.
--
To view, visit http://gerrit.cloudera.org:8080/3638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Anonymous Coward #149
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1517 Implement doc feedback from Sue M
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: KUDU-1517 Implement doc feedback from Sue M
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3638/1/docs/index.adoc
File docs/index.adoc:
PS1, Line 79: FROM
> Based on what Matt wrote, let's just say "you can specify complex joins wit
I might even avoid mentioning this "you can specify..." bit because it's not really about "complex joins", the behavior of the statements differs between UPDATE and DELETE, and I'm not sure we can do them justice in one sentence here. If we want to talk about them we should do so separately and be a bit more clear.
--
To view, visit http://gerrit.cloudera.org:8080/3638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Anonymous Coward #149
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1517 Implement doc feedback from Sue M
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: KUDU-1517 Implement doc feedback from Sue M
......................................................................
Patch Set 3: Code-Review+2
We can address my previous feedback in a follow-up commit if we want to get the rest of this in right away.
--
To view, visit http://gerrit.cloudera.org:8080/3638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Anonymous Coward #149
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1517 Implement doc feedback from Sue M
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: KUDU-1517 Implement doc feedback from Sue M
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2391/
--
To view, visit http://gerrit.cloudera.org:8080/3638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1517 Implement doc feedback from Sue M
Posted by "Misty Stanley-Jones (Code Review)" <ge...@cloudera.org>.
Misty Stanley-Jones has posted comments on this change.
Change subject: KUDU-1517 Implement doc feedback from Sue M
......................................................................
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/3638/1/docs/index.adoc
File docs/index.adoc:
PS1, Line 73: mechanism
> s/mechanisms/syntax/
Done
PS1, Line 74: any other table with HDFS or HBase persistenc
> as any other Impala table, like those using HDFS or HBase for persistence.
Done
PS1, Line 78: to
> s/to/with/
Done
PS1, Line 89: within
> s/within/used by/
Done
Line 108: Data Compression:: Because a given column contains only one type of data, pattern-based compression can
> nit: Would be nice to keep this line under 100 chars long
Done
PS1, Line 185: when using
> s/when using/in/
Done
PS1, Line 236: and
> nit: and and
Done
--
To view, visit http://gerrit.cloudera.org:8080/3638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1517 Implement doc feedback from Sue M
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: KUDU-1517 Implement doc feedback from Sue M
......................................................................
Patch Set 3:
Build Started http://104.196.14.100/job/kudu-gerrit/2923/
--
To view, visit http://gerrit.cloudera.org:8080/3638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Misty Stanley-Jones <mi...@apache.org>
Gerrit-Reviewer: Anonymous Coward #149
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Misty Stanley-Jones <mi...@apache.org>
Gerrit-HasComments: No