[jira] [Comment Edited] (FLINK-2155) Add an additional checkstyle validation for illegal imports

["Lokesh Rajaram (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572259#comment-14572259 ] 

Lokesh Rajaram edited comment on FLINK-2155 at 6/4/15 6:38 AM:
---------------------------------------------------------------

Checkstyle IllegalImport works only at package level. I could not get it working at class level. Looked at various options in checkstyle checks and nothing seems to suit our requirement. So, used illeaglImport for excluding packages(e.g. org.apache.flink.shaded). Used a regular expression for validating use of Class org.apache.commons.lang3.Validate. 


was (Author: lokeshrajaram):
Checkstyle IllegalImport works only at package level. I could get it working for a class. Looked at various options in checkstyle checks and nothing seems to suit our requirement. So, used illeaglImport for org.apache.flink.shaded package. Used a regular expression for validating use of org.apache.commons.lang3.Validate. 

> Add an additional checkstyle validation for illegal imports
> -----------------------------------------------------------
>
>                 Key: FLINK-2155
>                 URL: https://issues.apache.org/jira/browse/FLINK-2155
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Lokesh Rajaram
>            Assignee: Lokesh Rajaram
>
> Add an additional check-style validation for illegal imports.
> To begin with the following two package import are marked as illegal:
>      1. org.apache.commons.lang3.Validate
>      2. org.apache.flink.shaded.*
> Implementation based on: http://checkstyle.sourceforge.net/config_imports.html#IllegalImport



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)