You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@echarts.apache.org by GitBox <gi...@apache.org> on 2022/04/08 09:54:33 UTC

[GitHub] [echarts] emwinter opened a new issue, #16853: [Bug] markAreas disappear when zooming in

emwinter opened a new issue, #16853:
URL: https://github.com/apache/echarts/issues/16853

   ### Version
   
   5.3.2
   
   ### Link to Minimal Reproduction
   
   https://echarts.apache.org/examples/en/editor.html?c=line-sections
   
   ### Steps to Reproduce
   
   This code is from the given line chart example, extended by zooming functionality and exact limits for markAreas.
   
   ```
   option = {
     title: {
       text: 'Distribution of Electricity',
       subtext: 'Fake Data'
     },
     tooltip: {
       trigger: 'axis',
       axisPointer: {
         type: 'cross'
       }
     },
     toolbox: {
       show: true,
       feature: {
         saveAsImage: {}
       }
     },
   dataZoom: [{}], // WITH ZOOMING
     xAxis: {
       type: 'category',
       boundaryGap: false,
       // prettier-ignore
       data: ['00:00', '01:15', '02:30', '03:45', '05:00', '06:15', '07:30', '08:45', '10:00', '11:15', '12:30', '13:45', '15:00', '16:15', '17:30', '18:45', '20:00', '21:15', '22:30', '23:45']
     },
     yAxis: {
       type: 'value',
       axisLabel: {
         formatter: '{value} W'
       },
       axisPointer: {
         snap: true
       },
     },
     series: [
       {
         name: 'Electricity',
         type: 'line',
         smooth: true,
         // prettier-ignore
         data: [300, 280, 250, 260, 270, 300, 550, 500, 400, 390, 380, 390, 400, 500, 600, 750, 800, 700, 600, 400],
         markArea: {
           itemStyle: {
             color: 'rgba(255, 173, 177, 0.4)'
           },
           data: [
             [
               {
                 name: 'Morning Peak',
                 xAxis: '07:30',
                 
               },
               {
                 xAxis: '10:00',
                 yAxis: 700 // EXACT LIMIT HERE
               }
             ],
             [
               {
                 name: 'Evening Peak',
                 xAxis: '17:30'
               },
               {
                 xAxis: '21:15'
               }
             ],
             [
             {yAxis: 200}, {yAxis: 600, xAxis: '22:30'}, // EXACT LIMIT HERE
               ]
           ]
         }
       }
     ]
   };
   ```
   
   ### Current Behavior
   
   When applying limits for the markArea, and zooming in, the markAreas disappear. 
   
   So the initial view looks fine:
   
   ![image](https://user-images.githubusercontent.com/47206567/162408884-d0ff8935-612d-4129-bf11-d733d4b05d80.png)
   
   But when you start zooming, markAreas will disappear.
   
   ![image](https://user-images.githubusercontent.com/47206567/162409140-c00464e6-3ab0-4b45-8723-4c1eb02b985f.png)
   
   Also applied dataZoom filterMode with 'weakFilter', 'empty' and 'none', but these settings did not resolve the issue.
   
   ### Expected Behavior
   
   The markAreas should still be visible in the window, also when zooming in.
   
   ### Environment
   
   ```markdown
   - OS: macOS Big Sur
   - Browser: Chrome
   - Using one of the Echarts examples editor
   ```
   
   
   ### Any additional comments?
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org


[GitHub] [echarts] jiawulin001 commented on issue #16853: [Bug] markAreas disappear when zooming in

Posted by GitBox <gi...@apache.org>.
jiawulin001 commented on issue #16853:
URL: https://github.com/apache/echarts/issues/16853#issuecomment-1094594251

   @plainheart Although they are basically the same problem, but I suppose https://github.com/apache/echarts/pull/16026 is for markLine? And this one is about markArea. Correct me if https://github.com/apache/echarts/pull/16026 solves both problems.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang closed issue #16853: [Bug] markAreas disappear when zooming in

Posted by GitBox <gi...@apache.org>.
pissang closed issue #16853: [Bug] markAreas disappear when zooming in
URL: https://github.com/apache/echarts/issues/16853


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] plainheart commented on issue #16853: [Bug] markAreas disappear when zooming in

Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #16853:
URL: https://github.com/apache/echarts/issues/16853#issuecomment-1094608615

   Since the author @susiwen8 has no plan to fix it together with #16026, @jiawulin001 you're welcome to make a new one for `markArea`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] susiwen8 commented on issue #16853: [Bug] markAreas disappear when zooming in

Posted by GitBox <gi...@apache.org>.
susiwen8 commented on issue #16853:
URL: https://github.com/apache/echarts/issues/16853#issuecomment-1094287413

   - might relate to #15977


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] susiwen8 commented on issue #16853: [Bug] markAreas disappear when zooming in

Posted by GitBox <gi...@apache.org>.
susiwen8 commented on issue #16853:
URL: https://github.com/apache/echarts/issues/16853#issuecomment-1094596429

   > @plainheart Although they are basically the same problem, but I suppose #16026 is for markLine? And this one is about markArea. Correct me if #16026 solves both problems.
   
   @jiawulin001  Yes, you are right,  #16026 is for `markLine`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] jiawulin001 commented on issue #16853: [Bug] markAreas disappear when zooming in

Posted by GitBox <gi...@apache.org>.
jiawulin001 commented on issue #16853:
URL: https://github.com/apache/echarts/issues/16853#issuecomment-1094512349

   Right, as is said by @susiwen8 , this is a similar problem here:
   https://github.com/apache/echarts/blob/3b7ff4fc258b261a7754ab73e1b1424ce9c34437/src/component/marker/MarkAreaView.ts#L127-L137
   The filter is applied and allow markArea to stay only when at least one of the specified corner point of the markArea is in the coordinate system. That's why the markArea is clipped when zoom-in.
   The plan is to improve the judgment of whether the markArea is in coord. But to be honest, why not just set all markArea to showing ALL THE TIME? I believe that's too tiny to affect the performance.
   Submitting a PR to solve this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] zmyjs commented on issue #16853: [Bug] markAreas disappear when zooming in

Posted by GitBox <gi...@apache.org>.
zmyjs commented on issue #16853:
URL: https://github.com/apache/echarts/issues/16853#issuecomment-1225215332

   我也遇到了,解决办法了吗?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] plainheart commented on issue #16853: [Bug] markAreas disappear when zooming in

Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #16853:
URL: https://github.com/apache/echarts/issues/16853#issuecomment-1094518184

   @jiawulin001 Thanks for your information. There is currently an open pull request(#16026) to fix this issue. You can post your thoughts there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org