You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "kbowers-ibm (via GitHub)" <gi...@apache.org> on 2024/07/03 10:12:33 UTC
[PR] kie-issues#1374: KIE Sandbox: Resizing columns of Loan Pre-qualification Decision Table on Sample.dmn is breaking the model parsing [incubator-kie-tools]
kbowers-ibm opened a new pull request, #2458:
URL: https://github.com/apache/incubator-kie-tools/pull/2458
Closes https://github.com/apache/incubator-kie-issues/issues/1374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#1374: KIE Sandbox: Resizing columns of Loan Pre-qualification Decision Table on Sample.dmn is breaking the model parsing [incubator-kie-tools]
Posted by "kbowers-ibm (via GitHub)" <gi...@apache.org>.
kbowers-ibm commented on code in PR #2458:
URL: https://github.com/apache/incubator-kie-tools/pull/2458#discussion_r1689342649
##########
packages/online-editor/static/samples/Sample.dmn:
##########
Review Comment:
I did it at Tiago's request, as he wanted the widths to look nicer so that the cell's content is more easily readable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#1374: KIE Sandbox: Resizing columns of Loan Pre-qualification Decision Table on Sample.dmn is breaking the model parsing [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on PR #2458:
URL: https://github.com/apache/incubator-kie-tools/pull/2458#issuecomment-2243527241
Tests seem to be breaking on the CI.. @kbowers-ibm can you please check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#1374: KIE Sandbox: Resizing columns of Loan Pre-qualification Decision Table on Sample.dmn is breaking the model parsing [incubator-kie-tools]
Posted by "kbowers-ibm (via GitHub)" <gi...@apache.org>.
kbowers-ibm commented on PR #2458:
URL: https://github.com/apache/incubator-kie-tools/pull/2458#issuecomment-2206224397
This PR shouldn't cause any visible changes @jomarko. It will only change DMNs that have a decision table without appropriate kie:width tags. During my manual testing it seemed like files without said kie:width tags default to the minimum value, so it shouldn't affect any tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#1374: KIE Sandbox: Resizing columns of Loan Pre-qualification Decision Table on Sample.dmn is breaking the model parsing [incubator-kie-tools]
Posted by "ljmotta (via GitHub)" <gi...@apache.org>.
ljmotta commented on code in PR #2458:
URL: https://github.com/apache/incubator-kie-tools/pull/2458#discussion_r1688492331
##########
packages/boxed-expression-component/tests-e2e/features/resizing/resizing.spec.ts:
##########
@@ -238,6 +239,24 @@ test.describe("Resizing", () => {
expect(await nestedEntry.boundingBox()).toHaveProperty("width", 120);
expect(await nestedLiteralExpresison.boundingBox()).toHaveProperty("width", 212);
});
+
+ test("should assign width values to all columns when no width defined", async ({
+ stories,
+ page,
+ resizing,
+ jsonModel,
+ }) => {
+ test.info().annotations.push({
+ type: TestAnnotations.REGRESSION,
+ description: "https://github.com/apache/incubator-kie-issues/issues/1374",
+ });
+
+ await stories.openBoxedContext("installment-calculation");
+ const firstEntry = page.getByRole("cell", { name: "Fee (number)" });
+ await resizing.resizeCell(firstEntry, { x: 0, y: 0 }, { x: 50, y: 0 });
Review Comment:
I could see that you've created a variable as I've created on the first tests I've made using the `resize.resizeCell` fixture. Currently, we're tring to not add any variable on the tests. I guess it will change a little with the revamp on the Boxed Expression tests that Daniel is working on https://github.com/apache/incubator-kie-tools/pull/2456, but for this case, I can't see the necessity of a variable here, could you please inline it? The same applies for the other tests.
##########
packages/online-editor/static/samples/Sample.dmn:
##########
Review Comment:
Why we need to change the sample file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#1374: KIE Sandbox: Resizing columns of Loan Pre-qualification Decision Table on Sample.dmn is breaking the model parsing [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #2458:
URL: https://github.com/apache/incubator-kie-tools/pull/2458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#1374: KIE Sandbox: Resizing columns of Loan Pre-qualification Decision Table on Sample.dmn is breaking the model parsing [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on PR #2458:
URL: https://github.com/apache/incubator-kie-tools/pull/2458#issuecomment-2206449430
@jomarko I agree. Tests are needed for this. We need to create a regression test pointing to this bug. @jomarko can you help @kbowers-ibm in that regard? We can use the Playwright annotations for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org