You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/21 15:11:06 UTC
[GitHub] [skywalking-eyes] kezhenxu94 opened a new pull request #1: Styles-based comments, license files, tests
kezhenxu94 opened a new pull request #1:
URL: https://github.com/apache/skywalking-eyes/pull/1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] wu-sheng commented on a change in pull request #1: Styles-based comments, license files, tests
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #1:
URL: https://github.com/apache/skywalking-eyes/pull/1#discussion_r546766851
##########
File path: LICENSE
##########
@@ -199,3 +199,21 @@
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
+
+
+=======================================================================
+Apache SkyWalking Eyes Subcomponents:
+
+The Apache SkyWalking Eyes project contains subcomponents with separate copyright
+notices and license terms. Your use of the source code for the these
+subcomponents is subject to the terms and conditions of the following
+licenses.
+
+========================================================================
+MIT licenses
+========================================================================
+
+The following components are provided under the MIT license. See project link for details.
+The text of each license is also included at licenses/LICENSE-[project].txt.
+
+ languages.yaml from GitHub: https://github.com/github/linguist/blob/master/lib/linguist/languages.yml MIT
Review comment:
Is this related to the runtime? Could you explain a little about how we use this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 commented on a change in pull request #1: Styles-based comments, license files, tests
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #1:
URL: https://github.com/apache/skywalking-eyes/pull/1#discussion_r546770484
##########
File path: LICENSE
##########
@@ -199,3 +199,21 @@
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
+
+
+=======================================================================
+Apache SkyWalking Eyes Subcomponents:
+
+The Apache SkyWalking Eyes project contains subcomponents with separate copyright
+notices and license terms. Your use of the source code for the these
+subcomponents is subject to the terms and conditions of the following
+licenses.
+
+========================================================================
+MIT licenses
+========================================================================
+
+The following components are provided under the MIT license. See project link for details.
+The text of each license is also included at licenses/LICENSE-[project].txt.
+
+ languages.yaml from GitHub: https://github.com/github/linguist/blob/master/lib/linguist/languages.yml MIT
Review comment:
This file contains a full list of mappings between file types and their extensions, we parse this at runtime to get the mapping and map the extensions to our comment styles.
This could be downloaded at runtime, but that would be troublesome for people who have poor/no network access
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] wu-sheng commented on a change in pull request #1: Styles-based comments, license files, tests
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #1:
URL: https://github.com/apache/skywalking-eyes/pull/1#discussion_r546777209
##########
File path: LICENSE
##########
@@ -199,3 +199,21 @@
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
+
+
+=======================================================================
+Apache SkyWalking Eyes Subcomponents:
+
+The Apache SkyWalking Eyes project contains subcomponents with separate copyright
+notices and license terms. Your use of the source code for the these
+subcomponents is subject to the terms and conditions of the following
+licenses.
+
+========================================================================
+MIT licenses
+========================================================================
+
+The following components are provided under the MIT license. See project link for details.
+The text of each license is also included at licenses/LICENSE-[project].txt.
+
+ languages.yaml from GitHub: https://github.com/github/linguist/blob/master/lib/linguist/languages.yml MIT
Review comment:
> This file contains a full list of mappings between file types and their extensions, we parse this at runtime to get the mapping and map the extensions to our comment styles.
Then this should be included in source codes license and dist license.
> This could be downloaded at runtime, but that would be troublesome for people who have poor/no network access
No need, I was just checking from license perspective.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 merged pull request #1: Styles-based comments, license files, tests
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #1:
URL: https://github.com/apache/skywalking-eyes/pull/1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 commented on a change in pull request #1: Styles-based comments, license files, tests
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #1:
URL: https://github.com/apache/skywalking-eyes/pull/1#discussion_r546773133
##########
File path: LICENSE
##########
@@ -199,3 +199,21 @@
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
+
+
+=======================================================================
+Apache SkyWalking Eyes Subcomponents:
+
+The Apache SkyWalking Eyes project contains subcomponents with separate copyright
+notices and license terms. Your use of the source code for the these
+subcomponents is subject to the terms and conditions of the following
+licenses.
+
+========================================================================
+MIT licenses
+========================================================================
+
+The following components are provided under the MIT license. See project link for details.
+The text of each license is also included at licenses/LICENSE-[project].txt.
+
+ languages.yaml from GitHub: https://github.com/github/linguist/blob/master/lib/linguist/languages.yml MIT
Review comment:
Containing this file in our binary makes it more self-contained IMO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 commented on a change in pull request #1: Styles-based comments, license files, tests
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #1:
URL: https://github.com/apache/skywalking-eyes/pull/1#discussion_r546759994
##########
File path: LICENSE
##########
@@ -199,3 +199,21 @@
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
+
+
+=======================================================================
+Apache SkyWalking Eyes Subcomponents:
+
+The Apache SkyWalking Eyes project contains subcomponents with separate copyright
+notices and license terms. Your use of the source code for the these
+subcomponents is subject to the terms and conditions of the following
+licenses.
+
+========================================================================
+MIT licenses
+========================================================================
+
+The following components are provided under the MIT license. See project link for details.
+The text of each license is also included at licenses/LICENSE-[project].txt.
+
+ languages.yaml from GitHub: https://github.com/github/linguist/blob/master/lib/linguist/languages.yml MIT
Review comment:
@wu-sheng please recheck this, I copy this file from GitHub's linguist repo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 commented on pull request #1: Styles-based comments, license files, tests
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #1:
URL: https://github.com/apache/skywalking-eyes/pull/1#issuecomment-749043286
> Then this should be included in source codes license and dist license.
I think I did it (in riot LICENSE and dist/LICENSE)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] kezhenxu94 edited a comment on pull request #1: Styles-based comments, license files, tests
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on pull request #1:
URL: https://github.com/apache/skywalking-eyes/pull/1#issuecomment-749043286
> Then this should be included in source codes license and dist license.
I think I did it (in root LICENSE and dist/LICENSE)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-eyes] wu-sheng commented on a change in pull request #1: Styles-based comments, license files, tests
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #1:
URL: https://github.com/apache/skywalking-eyes/pull/1#discussion_r546766519
##########
File path: LICENSE
##########
@@ -199,3 +199,21 @@
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
+
+
+=======================================================================
+Apache SkyWalking Eyes Subcomponents:
+
+The Apache SkyWalking Eyes project contains subcomponents with separate copyright
+notices and license terms. Your use of the source code for the these
+subcomponents is subject to the terms and conditions of the following
+licenses.
+
+========================================================================
+MIT licenses
+========================================================================
+
+The following components are provided under the MIT license. See project link for details.
+The text of each license is also included at licenses/LICENSE-[project].txt.
+
+ languages.yaml from GitHub: https://github.com/github/linguist/blob/master/lib/linguist/languages.yml MIT
Review comment:
From the license's perspective, I think it is fine. About the paper work, I think you miss `licenses/LICENSE-linguist.txt`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org