You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2022/06/08 15:44:37 UTC

[GitHub] [libcloud] enr0n opened a new pull request, #1713: test: alleviate race conditions in test_retry_*

enr0n opened a new pull request, #1713:
URL: https://github.com/apache/libcloud/pull/1713

   ## Alleviate race conditions in test_retry_*
   
   ### Description
   
   The retry tests (test_retry_*) are inherently racy because they assume mock side effects
   will always finish before the timeout. If for some reason the execution is a bit slow,
   this can lead to the timeout beating the mocks, and the tests will fail. Adjust these tests
   to alleviate this issue.
   
   ### Status
   
   - done, ready for review
   
   ### Checklist (tick everything that applies)
   
   - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
   - [ ] Documentation
   - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
   - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] asfgit merged pull request #1713: test: alleviate race conditions in test_retry_*

Posted by GitBox <gi...@apache.org>.
asfgit merged PR #1713:
URL: https://github.com/apache/libcloud/pull/1713


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] Kami commented on pull request #1713: test: alleviate race conditions in test_retry_*

Posted by GitBox <gi...@apache.org>.
Kami commented on PR #1713:
URL: https://github.com/apache/libcloud/pull/1713#issuecomment-1158093108

   Merged, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [libcloud] Kami commented on pull request #1713: test: alleviate race conditions in test_retry_*

Posted by GitBox <gi...@apache.org>.
Kami commented on PR #1713:
URL: https://github.com/apache/libcloud/pull/1713#issuecomment-1158088425

   Thanks for the contribution.
   
   We intentionally tried to use as low timeout as possible to speed up the test run, but as you said, that is not the most robust thing and may result in failures on slower machines and similar.
   
   Think PR will only add 5 seconds or so to the overall unit tests run time so I think it should be fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org