You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2024/01/08 20:42:16 UTC
[PR] GH-39515: [PYTHON] Pass in type to `MapType.from_arrays` [arrow]
Fokko opened a new pull request, #39516:
URL: https://github.com/apache/arrow/pull/39516
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39515: [Python] Pass in type to `MapType.from_arrays` [arrow]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #39516:
URL: https://github.com/apache/arrow/pull/39516#issuecomment-1883944249
Thanks for the quick review @AlenkaF 🙌 I've just added a couple more tests, let me know if this is what you're looking for 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39515: [Python] Pass in type to `MapType.from_arrays` [arrow]
Posted by "ianmcook (via GitHub)" <gi...@apache.org>.
ianmcook commented on code in PR #39516:
URL: https://github.com/apache/arrow/pull/39516#discussion_r1446806459
##########
python/pyarrow/tests/test_array.py:
##########
@@ -1057,6 +1057,31 @@ def test_map_from_arrays():
assert result.equals(expected)
+ result = pa.MapArray.from_arrays(offsets, keys, items, pa.map_(
+ keys.type,
+ items.type
+ ))
+ assert result.equals(expected)
+
+ pa.MapArray.from_arrays(offsets, keys, items, pa.map_(
+ keys.type,
+ # Bigger than the original i4, which is okay
+ pa.int32()
+ ))
+ assert result.equals(expected)
+
+ with pytest.raises(pa.ArrowTypeError, match='Expected map type, got string'):
+ pa.MapArray.from_arrays(offsets, keys, items, pa.string())
+
+ with pytest.raises(pa.ArrowTypeError, match='Mismatching map items type'):
+ pa.MapArray.from_arrays(offsets, keys, items, pa.map_(
+ keys.type,
+ # This is not allowed
+ pa.string()
+ ))
+
+ assert result.equals(expected)
Review Comment:
Are these lines needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39515: [Python] Pass in type to `MapType.from_arrays` [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39516:
URL: https://github.com/apache/arrow/pull/39516#issuecomment-1884487765
Revision: b45a4133f0be6f859f113cf5a57b22aac38cbbdc
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2bc8454e04](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2bc8454e04)
|Task|Status|
|----|------|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855619/job/20335852084)|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/7472854862/job/20335848642)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855816/job/20335853744)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/7472854382/job/20335846657)|
|test-conda-python-3.10-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/7472856338/job/20335888100)|
|test-conda-python-3.10-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/7472854749/job/20335847978)|
|test-conda-python-3.10-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/7472854442/job/20335847233)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855613/job/20335852038)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/7472854938/job/20335849122)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/7472854705/job/20335847946)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855820/job/20335853452)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855255/job/20335850531)|
|test-conda-python-3.11-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855811/job/20335853434)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855456/job/20335851491)|
|test-conda-python-3.12|[](https://github.com/ursacomputing/crossbow/actions/runs/7472854843/job/20335848535)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855907/job/20335853921)|
|test-conda-python-3.8-pandas-1.0|[](https://github.com/ursacomputing/crossbow/actions/runs/7472856086/job/20335887971)|
|test-conda-python-3.8-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855104/job/20335849637)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855548/job/20335851864)|
|test-conda-python-3.9-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855475/job/20335851502)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855686/job/20335852688)|
|test-debian-11-python-3|[](https://github.com/ursacomputing/crossbow/runs/20335850776)|
|test-fedora-38-python-3|[](https://github.com/ursacomputing/crossbow/runs/20335852514)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/runs/20335848473)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/7472854302/job/20335846506)|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855388/job/20335851146)|
|wheel-macos-big-sur-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855978/job/20335854581)|
|wheel-macos-big-sur-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472854387/job/20335846833)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855138/job/20335850008)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855979/job/20335854276)|
|wheel-macos-catalina-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855085/job/20335849434)|
|wheel-macos-catalina-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855657/job/20335852518)|
|wheel-macos-catalina-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855024/job/20335849162)|
|wheel-macos-catalina-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855152/job/20335849996)|
|wheel-macos-catalina-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472854813/job/20335848142)|
|wheel-manylinux-2-28-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472856022/job/20335854681)|
|wheel-manylinux-2-28-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855951/job/20335854157)|
|wheel-manylinux-2-28-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855181/job/20335850128)|
|wheel-manylinux-2-28-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855840/job/20335853532)|
|wheel-manylinux-2-28-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855215/job/20335850371)|
|wheel-manylinux-2-28-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855374/job/20335850920)|
|wheel-manylinux-2-28-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472854910/job/20335848965)|
|wheel-manylinux-2-28-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472854194/job/20335846306)|
|wheel-manylinux-2-28-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472856252/job/20335888027)|
|wheel-manylinux-2-28-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472854489/job/20335847552)|
|wheel-manylinux-2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855392/job/20335851026)|
|wheel-manylinux-2014-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855129/job/20335849817)|
|wheel-manylinux-2014-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472854572/job/20335847596)|
|wheel-manylinux-2014-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855775/job/20335852974)|
|wheel-manylinux-2014-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855764/job/20335852900)|
|wheel-manylinux-2014-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855968/job/20335854184)|
|wheel-manylinux-2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472854367/job/20335846660)|
|wheel-manylinux-2014-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472854574/job/20335847618)|
|wheel-manylinux-2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472854827/job/20335848727)|
|wheel-manylinux-2014-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855439/job/20335851225)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472854797/job/20335848136)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855894/job/20335853994)|
|wheel-windows-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472855043/job/20335849344)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472854346/job/20335846630)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7472854460/job/20335847204)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39515: [Python] Pass in type to `MapType.from_arrays` [arrow]
Posted by "ianmcook (via GitHub)" <gi...@apache.org>.
ianmcook commented on code in PR #39516:
URL: https://github.com/apache/arrow/pull/39516#discussion_r1446806459
##########
python/pyarrow/tests/test_array.py:
##########
@@ -1057,6 +1057,31 @@ def test_map_from_arrays():
assert result.equals(expected)
+ result = pa.MapArray.from_arrays(offsets, keys, items, pa.map_(
+ keys.type,
+ items.type
+ ))
+ assert result.equals(expected)
+
+ pa.MapArray.from_arrays(offsets, keys, items, pa.map_(
+ keys.type,
+ # Bigger than the original i4, which is okay
+ pa.int32()
+ ))
+ assert result.equals(expected)
+
+ with pytest.raises(pa.ArrowTypeError, match='Expected map type, got string'):
+ pa.MapArray.from_arrays(offsets, keys, items, pa.string())
+
+ with pytest.raises(pa.ArrowTypeError, match='Mismatching map items type'):
+ pa.MapArray.from_arrays(offsets, keys, items, pa.map_(
+ keys.type,
+ # This is not allowed
+ pa.string()
+ ))
+
+ assert result.equals(expected)
Review Comment:
```suggestion
```
Are these lines needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39515: [Python] Pass in type to `MapType.from_arrays` [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #39516:
URL: https://github.com/apache/arrow/pull/39516#discussion_r1447218502
##########
python/pyarrow/array.pxi:
##########
@@ -2467,7 +2467,7 @@ cdef class MapArray(ListArray):
"""
@staticmethod
- def from_arrays(offsets, keys, items, MemoryPool pool=None):
+ def from_arrays(offsets, keys, items, DataType type=None, MemoryPool pool=None):
Review Comment:
is there a reason to use `type` as a variable name? `type` is [a built-in function in Python](https://docs.python.org/3/library/functions.html#type) and unless necessary could we call it `datatype` or `data_type`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39515: [PYTHON] Pass in type to `MapType.from_arrays` [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39516:
URL: https://github.com/apache/arrow/pull/39516#issuecomment-1881790248
:warning: GitHub issue #39515 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39515: [Python] Pass in type to `MapType.from_arrays` [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #39516:
URL: https://github.com/apache/arrow/pull/39516#issuecomment-1884481270
@github-actions crossbow submit -g python -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39515: [Python] Pass in type to `MapType.from_arrays` [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #39516:
URL: https://github.com/apache/arrow/pull/39516#discussion_r1447274641
##########
python/pyarrow/array.pxi:
##########
@@ -2467,7 +2467,7 @@ cdef class MapArray(ListArray):
"""
@staticmethod
- def from_arrays(offsets, keys, items, MemoryPool pool=None):
+ def from_arrays(offsets, keys, items, DataType type=None, MemoryPool pool=None):
Review Comment:
oh! I see, I did a search and didn't found other occurrences. Thanks @AlenkaF for pointing that out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39515: [Python] Pass in type to `MapType.from_arrays` [arrow]
Posted by "ianmcook (via GitHub)" <gi...@apache.org>.
ianmcook commented on code in PR #39516:
URL: https://github.com/apache/arrow/pull/39516#discussion_r1446806459
##########
python/pyarrow/tests/test_array.py:
##########
@@ -1057,6 +1057,31 @@ def test_map_from_arrays():
assert result.equals(expected)
+ result = pa.MapArray.from_arrays(offsets, keys, items, pa.map_(
+ keys.type,
+ items.type
+ ))
+ assert result.equals(expected)
+
+ pa.MapArray.from_arrays(offsets, keys, items, pa.map_(
+ keys.type,
+ # Bigger than the original i4, which is okay
+ pa.int32()
+ ))
+ assert result.equals(expected)
+
+ with pytest.raises(pa.ArrowTypeError, match='Expected map type, got string'):
+ pa.MapArray.from_arrays(offsets, keys, items, pa.string())
+
+ with pytest.raises(pa.ArrowTypeError, match='Mismatching map items type'):
+ pa.MapArray.from_arrays(offsets, keys, items, pa.map_(
+ keys.type,
+ # This is not allowed
+ pa.string()
+ ))
+
+ assert result.equals(expected)
Review Comment:
```suggestion
```
I think this can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39515: [Python] Pass in type to `MapType.from_arrays` [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #39516:
URL: https://github.com/apache/arrow/pull/39516#issuecomment-1885146123
@github-actions crossbow submit -g python -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39515: [Python] Pass in type to `MapType.from_arrays` [arrow]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #39516:
URL: https://github.com/apache/arrow/pull/39516#issuecomment-1885256695
Thanks @AlenkaF, @ianmcook and @raulcd for the quick review and merge 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39515: [Python] Pass in type to `MapType.from_arrays` [arrow]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #39516:
URL: https://github.com/apache/arrow/pull/39516#discussion_r1447453332
##########
python/pyarrow/tests/test_array.py:
##########
@@ -1057,6 +1057,31 @@ def test_map_from_arrays():
assert result.equals(expected)
+ result = pa.MapArray.from_arrays(offsets, keys, items, pa.map_(
+ keys.type,
+ items.type
+ ))
+ assert result.equals(expected)
+
+ pa.MapArray.from_arrays(offsets, keys, items, pa.map_(
+ keys.type,
+ # Bigger than the original i4, which is okay
+ pa.int32()
+ ))
+ assert result.equals(expected)
Review Comment:
Thanks! I'm not too familiar with the `numpy` types, thanks for pointing that out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39515: [Python] Pass in type to `MapType.from_arrays` [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF merged PR #39516:
URL: https://github.com/apache/arrow/pull/39516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39515: [Python] Pass in type to `MapType.from_arrays` [arrow]
Posted by "ianmcook (via GitHub)" <gi...@apache.org>.
ianmcook commented on code in PR #39516:
URL: https://github.com/apache/arrow/pull/39516#discussion_r1446807479
##########
python/pyarrow/tests/test_array.py:
##########
@@ -1057,6 +1057,31 @@ def test_map_from_arrays():
assert result.equals(expected)
+ result = pa.MapArray.from_arrays(offsets, keys, items, pa.map_(
+ keys.type,
+ items.type
+ ))
+ assert result.equals(expected)
+
+ pa.MapArray.from_arrays(offsets, keys, items, pa.map_(
+ keys.type,
+ # Bigger than the original i4, which is okay
+ pa.int32()
+ ))
+ assert result.equals(expected)
Review Comment:
Does this assertion serve a purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39515: [Python] Pass in type to `MapType.from_arrays` [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #39516:
URL: https://github.com/apache/arrow/pull/39516#issuecomment-1887590982
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 07a46555e74501f96973dc43ef54a4669d261876.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/20394810726) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39515: [Python] Pass in type to `MapType.from_arrays` [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #39516:
URL: https://github.com/apache/arrow/pull/39516#discussion_r1446986682
##########
python/pyarrow/tests/test_array.py:
##########
@@ -1057,6 +1057,31 @@ def test_map_from_arrays():
assert result.equals(expected)
+ result = pa.MapArray.from_arrays(offsets, keys, items, pa.map_(
+ keys.type,
+ items.type
+ ))
+ assert result.equals(expected)
+
+ pa.MapArray.from_arrays(offsets, keys, items, pa.map_(
+ keys.type,
+ # Bigger than the original i4, which is okay
+ pa.int32()
+ ))
+ assert result.equals(expected)
Review Comment:
Yeah, I think `result = ...` is missing in line 1066.
And for the type-double-check, `pa.int32` and numpy `i4` should be same?
If we were to use `pa.int64` the construction of a MapArray should not fail, but the assertion would, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39515: [Python] Pass in type to `MapType.from_arrays` [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #39516:
URL: https://github.com/apache/arrow/pull/39516#discussion_r1447263108
##########
python/pyarrow/array.pxi:
##########
@@ -2467,7 +2467,7 @@ cdef class MapArray(ListArray):
"""
@staticmethod
- def from_arrays(offsets, keys, items, MemoryPool pool=None):
+ def from_arrays(offsets, keys, items, DataType type=None, MemoryPool pool=None):
Review Comment:
Agree but at the same time, we seem to be using `type` elsewhere also. For example:
https://github.com/apache/arrow/blob/72ed58449ea71aab1343d9adce19f177f20705cf/python/pyarrow/array.pxi#L2139C15-L2145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39515: [Python] Pass in type to `MapType.from_arrays` [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39516:
URL: https://github.com/apache/arrow/pull/39516#issuecomment-1885152193
Revision: 0f648d9a354353ebb7350a9356c67311d4ad8138
Submitted crossbow builds: [ursacomputing/crossbow @ actions-661760e6ba](https://github.com/ursacomputing/crossbow/branches/all?query=actions-661760e6ba)
|Task|Status|
|----|------|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622732/job/20350724088)|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/7477621504/job/20350716937)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622956/job/20350725649)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/7477621760/job/20350718366)|
|test-conda-python-3.10-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622315/job/20350721306)|
|test-conda-python-3.10-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622791/job/20350724371)|
|test-conda-python-3.10-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622497/job/20350722209)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622273/job/20350720983)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622223/job/20350720990)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/7477623249/job/20350726365)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622399/job/20350722228)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/7477623228/job/20350726359)|
|test-conda-python-3.11-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622653/job/20350724089)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/7477621774/job/20350718304)|
|test-conda-python-3.12|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622302/job/20350721042)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622709/job/20350724075)|
|test-conda-python-3.8-pandas-1.0|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622925/job/20350724494)|
|test-conda-python-3.8-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622086/job/20350719788)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/7477623206/job/20350726322)|
|test-conda-python-3.9-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/7477623177/job/20350726210)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622998/job/20350725666)|
|test-debian-11-python-3|[](https://github.com/ursacomputing/crossbow/runs/20350720631)|
|test-fedora-38-python-3|[](https://github.com/ursacomputing/crossbow/runs/20350721449)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/runs/20350722534)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/7477621565/job/20350717094)|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477623178/job/20350726008)|
|wheel-macos-big-sur-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477621858/job/20350718320)|
|wheel-macos-big-sur-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477623006/job/20350725700)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477621861/job/20350718583)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477623450/job/20350764679)|
|wheel-macos-catalina-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622989/job/20350725697)|
|wheel-macos-catalina-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477621526/job/20350716932)|
|wheel-macos-catalina-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477621700/job/20350718342)|
|wheel-macos-catalina-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622564/job/20350723166)|
|wheel-macos-catalina-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622932/job/20350724612)|
|wheel-manylinux-2-28-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477621950/job/20350718984)|
|wheel-manylinux-2-28-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477623031/job/20350725949)|
|wheel-manylinux-2-28-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477623118/job/20350725972)|
|wheel-manylinux-2-28-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477623240/job/20350726597)|
|wheel-manylinux-2-28-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622637/job/20350724062)|
|wheel-manylinux-2-28-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622823/job/20350724330)|
|wheel-manylinux-2-28-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622215/job/20350720731)|
|wheel-manylinux-2-28-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622042/job/20350719370)|
|wheel-manylinux-2-28-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622091/job/20350719787)|
|wheel-manylinux-2-28-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622179/job/20350720738)|
|wheel-manylinux-2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622767/job/20350724311)|
|wheel-manylinux-2014-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622196/job/20350720712)|
|wheel-manylinux-2014-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622519/job/20350723129)|
|wheel-manylinux-2014-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477623324/job/20350726704)|
|wheel-manylinux-2014-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622589/job/20350723177)|
|wheel-manylinux-2014-cp312-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477621991/job/20350719004)|
|wheel-manylinux-2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622613/job/20350723390)|
|wheel-manylinux-2014-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622536/job/20350723116)|
|wheel-manylinux-2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622232/job/20350720967)|
|wheel-manylinux-2014-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477621694/job/20350717866)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477623111/job/20350726031)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477623247/job/20350726685)|
|wheel-windows-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477621553/job/20350716928)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622343/job/20350721291)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/7477622137/job/20350719803)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org